public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] ARM & u-boot-next pull request
Date: Sun, 21 Sep 2008 22:11:14 +0200	[thread overview]
Message-ID: <20080921201114.28943248CD@gemini.denx.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0809212104400.7264@axis700.grange>

Dear Jean-Christophe,

in message <Pine.LNX.4.64.0809212104400.7264@axis700.grange>
Guennadi Liakhovetski wrote:
> 
> > Jean-Christophe PLAGNIOL-VILLARD (4):
> >       Revert "ARM: set GD_FLG_RELOC for boards skipping relocation to RAM"
> >       ARM: set GD_FLG_RELOC at board init
> 
> This patch's commit doesn't seem right to me. The original patch is:
> 
> From: gnusercn <gnusercn@gmail.com>
> Date: Tue, 22 Jul 2008 10:35:58 +0800
> Subject: [PATCH] Fix bug: in arch-arm, env_get_char dose not work fine in u-boot 1.3.4-rc1
> 
> Signed-off-by: gnusercn <gnusercn@gmail.com>
> 
> Ok, the patch was corrputed - it had 4 spaces indentation in all lines 
> instead of TABs, but I don't think this is sufficient reason to commit an 
> otherwise identical patch with a different author and without the 
> original Sob. I think, this is a _very_ bad idea.

I agree with Guennadi. Please fix this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is a time in the tides of men, Which, taken at its flood, leads
on to success. On the other hand, don't count on it.   - T. K. Lawson

  reply	other threads:[~2008-09-21 20:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-18 15:02 [U-Boot] ARM & u-boot-next pull request Jean-Christophe PLAGNIOL-VILLARD
2008-09-21 16:13 ` [U-Boot] OMAP3 patches and u-boot-next, was: " Dirk Behme
2008-09-21 19:12 ` [U-Boot] " Guennadi Liakhovetski
2008-09-21 20:11   ` Wolfgang Denk [this message]
2008-09-21 20:59 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080921201114.28943248CD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox