From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] bootm: Add sub commands
Date: Mon, 22 Sep 2008 23:06:18 +0200 [thread overview]
Message-ID: <20080922210618.BE687248EE@gemini.denx.de> (raw)
In-Reply-To: <6ADB3DCC-693A-41EB-BDCD-0B20865F677E@kernel.crashing.org>
Dear Kumar Gala,
In message <6ADB3DCC-693A-41EB-BDCD-0B20865F677E@kernel.crashing.org> you wrote:
>
> >> + /* start */
> >> + if (argv[1][0] == 's') {
> >
> > I think just matching on the first letter is to restrictive; we'll end
> > up with artificical command "names" that nobody can remember.
>
> I'm happy to move to using strncmp, but I agree with Jerry that other
> subcommand do the shortest match possible.
Agreed. The shortest unambiguous match shall be sufficient. On the
other hand we should allow for longer subcopmmand names, or we'll
very soon see artifical command identifiers that nobody can remember
well because they were artificially chosen to use a still unused
letter.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have made mistakes, but have never made the mistake of claiming I
never made one. - James G. Bennet
next prev parent reply other threads:[~2008-09-22 21:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 22:00 [U-Boot] [RFC] bootm: Add sub commands Kumar Gala
2008-09-17 23:57 ` Jerry Van Baren
2008-09-18 16:27 ` Kumar Gala
2008-09-18 6:54 ` Wolfgang Denk
2008-09-18 11:25 ` Jerry Van Baren
2008-09-18 16:32 ` Kumar Gala
2008-09-22 21:06 ` Wolfgang Denk [this message]
2008-09-18 20:17 ` Kumar Gala
2008-09-22 21:09 ` Wolfgang Denk
2008-09-22 23:32 ` Kumar Gala
2008-09-22 23:49 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080922210618.BE687248EE@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox