public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: Divided pci code of the powerpc
Date: Tue, 23 Sep 2008 10:04:39 +0200	[thread overview]
Message-ID: <200809231004.40323.sr@denx.de> (raw)
In-Reply-To: <2acbd3e40809221741t6756df4bud550b1efdd6f86f2@mail.gmail.com>

On Tuesday 23 September 2008, Andy Fleming wrote:
> >>> I did a simple check.
> >>>
> >>> Only powerpc and i386 and sh seem to use PCI.
> >>> If powerpc does not have a problem, would you commit it?
> >>
> >> Do I have your "go" (or at least no veto) to apply this patch?
>
> If some of that code is powerpc-only, maybe we should move the code
> out of pci.c, too?  pci_hose_phys_to_bus() appears to be...
> board/eltec/bab7xx/pci.c only, actually.

That doesn't seem to be correct. In include/pci.h:

#define pci_phys_to_bus(dev, addr, flags) \
	pci_hose_phys_to_bus(pci_bus_to_hose(PCI_BUS(dev)), (addr), (flags))

and later:

#define pci_phys_to_mem(dev, addr)	pci_phys_to_bus((dev), (addr), PCI_REGION_MEM)
#define pci_phys_to_io(dev, addr)	pci_phys_to_bus((dev), (addr), PCI_REGION_IO)

So calling pci_phys_to_mem() or pci_phys_to_io() leads to a
pci_hose_phys_to_bus() call in the end.


Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-09-23  8:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29  1:39 [U-Boot] [PATCH] pci: Divided pci code of the powerpc Nobuhiro Iwamatsu
2008-09-06 22:11 ` Wolfgang Denk
2008-09-18  3:36   ` Nobuhiro Iwamatsu
2008-09-18  6:26     ` Graeme Russ
2008-09-22 20:11     ` Wolfgang Denk
2008-09-22 20:33       ` Andrew Dyer
2008-09-23  0:41         ` Andy Fleming
2008-09-23  8:04           ` Stefan Roese [this message]
2008-09-23  8:03         ` Stefan Roese
2008-09-24  1:22           ` Nobuhiro Iwamatsu
2008-09-25  7:29             ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809231004.40323.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox