public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: Divided pci code of the powerpc
Date: Thu, 25 Sep 2008 09:29:47 +0200	[thread overview]
Message-ID: <200809250929.47591.sr@denx.de> (raw)
In-Reply-To: <29ab51dc0809231822x5f79467qedfef26c44fadc30@mail.gmail.com>

On Wednesday 24 September 2008, Nobuhiro Iwamatsu wrote:
> > BTW: I fail to see what's really PPC specific about the pci code in
> > question. Nobuhiro, could you please elaborate what's the problem here?
>
> I wanted to remove CPU and baords of specific code from from PCI network
> driver. CONFIG_E500, DB64360 and DB64460  CPU is PPC.

Now I understand. You are referring to code like this:

drivers/net/eepro100.c:

#if defined(CONFIG_E500) || defined(CONFIG_DB64360) || defined(CONFIG_DB64460)
#define bus_to_phys(a) (a)
#define phys_to_bus(a) (a)
#else
#define bus_to_phys(a)  pci_mem_to_phys((pci_dev_t)dev->priv, a)
#define phys_to_bus(a)  pci_phys_to_mem((pci_dev_t)dev->priv, a)
#endif

> I thought that I could collect these with header files of PPC.
> Therefore I sent that patch in RFC.

Yes, it definitely is a good idea to move those defines to platform/cpu 
headers.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2008-09-25  7:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29  1:39 [U-Boot] [PATCH] pci: Divided pci code of the powerpc Nobuhiro Iwamatsu
2008-09-06 22:11 ` Wolfgang Denk
2008-09-18  3:36   ` Nobuhiro Iwamatsu
2008-09-18  6:26     ` Graeme Russ
2008-09-22 20:11     ` Wolfgang Denk
2008-09-22 20:33       ` Andrew Dyer
2008-09-23  0:41         ` Andy Fleming
2008-09-23  8:04           ` Stefan Roese
2008-09-23  8:03         ` Stefan Roese
2008-09-24  1:22           ` Nobuhiro Iwamatsu
2008-09-25  7:29             ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809250929.47591.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox