From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 25 Sep 2008 09:29:47 +0200
Subject: [U-Boot] [PATCH] pci: Divided pci code of the powerpc
In-Reply-To: <29ab51dc0809231822x5f79467qedfef26c44fadc30@mail.gmail.com>
References: <20080829103949.022a6e45.iwamatsu@nigauri.org>
	<200809231003.06829.sr@denx.de>
	<29ab51dc0809231822x5f79467qedfef26c44fadc30@mail.gmail.com>
Message-ID: <200809250929.47591.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 24 September 2008, Nobuhiro Iwamatsu wrote:
> > BTW: I fail to see what's really PPC specific about the pci code in
> > question. Nobuhiro, could you please elaborate what's the problem here?
>
> I wanted to remove CPU and baords of specific code from from PCI network
> driver. CONFIG_E500, DB64360 and DB64460  CPU is PPC.

Now I understand. You are referring to code like this:

drivers/net/eepro100.c:

#if defined(CONFIG_E500) || defined(CONFIG_DB64360) || defined(CONFIG_DB64460)
#define bus_to_phys(a) (a)
#define phys_to_bus(a) (a)
#else
#define bus_to_phys(a)  pci_mem_to_phys((pci_dev_t)dev->priv, a)
#define phys_to_bus(a)  pci_phys_to_mem((pci_dev_t)dev->priv, a)
#endif

> I thought that I could collect these with header files of PPC.
> Therefore I sent that patch in RFC.

Yes, it definitely is a good idea to move those defines to platform/cpu 
headers.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================