From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx
Date: Fri, 26 Sep 2008 07:46:19 +0200 [thread overview]
Message-ID: <20080926054619.2D3F1248CD@gemini.denx.de> (raw)
In-Reply-To: <48DC5A97.20305@gmail.com>
Dear Jerry Van Baren,
In message <48DC5A97.20305@gmail.com> you wrote:
>
> Here is where a modification Kumar's loop (I would loop over
> /aliases/ethernet[N] instead of the env variables) would cut out 5
> copies of the same code and would scale infinitely. Hmmm, we have
> MAXCONTROLLERS (CONFIG_NUM_ETH?) to tell us how many etherspiggots we
> have, can we loop on that?
>
> I would also *strongly* prefer eliminating bd->bi_enet[N]addr variables,
> are they needed at all in a fdt-enabled system? Are there any other
> places that bd->bi_enet[N]addr is used? If the only use is here, to
> print out the MAC addresses, we can do Kumar's loop and print the env
> variables directly instead of converting the env variable to
> bd->enet[N]addr and then back into ASCII. Bleah.
There are fdt-less systems around, and will be, at least for a looong
time.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How can you tell when sour cream goes bad?
next prev parent reply other threads:[~2008-09-26 5:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 12:53 [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx richardretanubun
2008-09-25 19:50 ` Kim Phillips
2008-09-25 20:25 ` richardretanubun
2008-09-25 20:45 ` Kim Phillips
2008-09-25 22:08 ` Wolfgang Denk
2008-09-25 21:44 ` [U-Boot] [PATCH v2] " richardretanubun
2008-09-25 22:24 ` Wolfgang Denk
2008-09-25 22:52 ` richardretanubun
2008-09-25 23:28 ` Wolfgang Denk
2008-09-29 12:43 ` richardretanubun
2008-09-29 13:07 ` Jerry Van Baren
2008-09-29 22:28 ` [U-Boot] [PATCH v3] " richardretanubun
2008-09-30 16:00 ` Kim Phillips
2008-09-30 15:58 ` Jerry Van Baren
2008-09-30 17:02 ` Ben Warren
2008-10-06 5:12 ` Ben Warren
2008-10-06 19:31 ` richardretanubun
2008-10-14 5:53 ` Ben Warren
2008-09-25 22:24 ` [U-Boot] [PATCH] " Wolfgang Denk
2008-09-25 20:42 ` Jerry Van Baren
2008-09-25 22:17 ` Wolfgang Denk
2008-09-26 3:44 ` Jerry Van Baren
2008-09-26 5:46 ` Wolfgang Denk [this message]
2008-09-26 7:21 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926054619.2D3F1248CD@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox