public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [sensor]: Make the LM75 MULTI_BUS compatible.
Date: Mon, 29 Sep 2008 11:15:17 +0200	[thread overview]
Message-ID: <20080929091517.73056248CD@gemini.denx.de> (raw)
In-Reply-To: <48E089B7.8020201@denx.de>

Dear Heiko Schocher,

In message <48E089B7.8020201@denx.de> you wrote:
> also fix CodingStyle issues for the LM75
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>  drivers/hwmon/lm75.c |  228 +++++++++++++++++++++++---------------------------
>  1 files changed, 105 insertions(+), 123 deletions(-)
> 
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 67a18f6..b95601d 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -50,159 +50,141 @@
> 
>  int dtt_read(int sensor, int reg)
>  {
> -    int dlen;
> -    uchar data[2];
> +	int dlen;
> +	uchar data[2];
> 

Please split your additions and any code clean up into separate
patches. As is, it's impossible to see what you actually changed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If it went on at this rate, in several billion  years  he'd  be  rich
beyond his wildest dreams!            - Terry Pratchett, _Soul Music_

      parent reply	other threads:[~2008-09-29  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29  7:54 [U-Boot] [PATCH] [sensor]: Make the LM75 MULTI_BUS compatible Heiko Schocher
2008-09-29  8:40 ` Stefan Roese
2008-09-29  9:15 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080929091517.73056248CD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox