From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Red Black Tree support
Date: Mon, 06 Oct 2008 09:26:29 +0200 [thread overview]
Message-ID: <20081006072629.5F60281AA426@gemini.denx.de> (raw)
In-Reply-To: <20081006014744.GA5438@july>
Dear Kyungmin Park,
In message <20081006014744.GA5438@july> you wrote:
> RB-tree support on U-Boot
> Now it's used at UBI module. Of course other modules can use it.
...
I understand the code is a verbatim copy from the LInux kernel?
Otherwise the coding style violations would not be acceptable.
> diff --git a/lib_generic/Makefile b/lib_generic/Makefile
> index 7df5a2c..83b41ca 100644
> --- a/lib_generic/Makefile
> +++ b/lib_generic/Makefile
> @@ -45,6 +45,7 @@ COBJS-y += string.o
> COBJS-y += strmhz.o
> COBJS-y += vsprintf.o
> COBJS-y += zlib.o
> +COBJS-y += rbtree.o
I expect that only few systems will actually use this, so it must be
configurable. It makes no sense to build this for ALL systems. Please
add a config option.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Reader, suppose you were an idiot. And suppose you were a member of
Congress. But I repeat myself. - Mark Twain
next prev parent reply other threads:[~2008-10-06 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 1:47 [U-Boot] [PATCH] Red Black Tree support Kyungmin Park
2008-10-06 7:26 ` Wolfgang Denk [this message]
2008-10-06 9:04 ` Amit Kumar Sharma
2008-10-08 1:44 ` Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006072629.5F60281AA426@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox