From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support
Date: Tue, 7 Oct 2008 12:26:14 -0500 [thread overview]
Message-ID: <20081007172614.GA3438@loki.buserror.net> (raw)
In-Reply-To: <48EB2F0E.4090805@googlemail.com>
On Tue, Oct 07, 2008 at 11:42:38AM +0200, Dirk Behme wrote:
>> Is it OK if config gets written before control, or if this whole thing
>> gets done out of order with respect to other raw writes?
>
> Hmm. I replaced this with the version from Nishanth's U-Boot v2 (see
> link above). If this isn't ok, can you explain a little more?
I was referring to the raw accessors, which you removed, so it's OK.
> I.e. with patch in attachment we don't touch nand_base.c any more, but
> still have an #ifdeffed user command in cmd_nand.c. If you don't like
> this, please give a hint how to better do this.
If at all possible, fix Linux to accept hardware ECC.
Otherwise, either add something to the MTD API that the nand command can
call, or have your own board-specific command defined in the board file.
Don't put platform-specific ifdefs in generic files.
-Scott
next prev parent reply other threads:[~2008-10-07 17:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 10:40 [U-Boot] [PATCH 07/12 v2] ARM: OMAP3: Add memory and syslib common files, add NAND support dirk.behme at googlemail.com
2008-10-03 16:52 ` Scott Wood
2008-10-03 17:08 ` Dirk Behme
2008-10-07 9:42 ` Dirk Behme
2008-10-07 11:25 ` Nishanth Menon
2008-10-07 17:30 ` Scott Wood
2008-10-07 17:45 ` Menon, Nishanth
2008-10-07 17:47 ` Scott Wood
2008-10-07 17:56 ` Dirk Behme
2008-10-07 20:47 ` Dirk Behme
2008-10-07 17:26 ` Scott Wood [this message]
2008-10-07 17:55 ` Dirk Behme
2008-10-07 17:59 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081007172614.GA3438@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox