public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes
@ 2008-10-08  8:54 Remy Bohmer
  2008-10-08  8:54 ` [U-Boot] [patch 1/2] fix USB initialisation procedure Remy Bohmer
                   ` (4 more replies)
  0 siblings, 5 replies; 21+ messages in thread
From: Remy Bohmer @ 2008-10-08  8:54 UTC (permalink / raw)
  To: u-boot

The USB OHCI init procedure sets the maximum message length the wrong way.
A max of 64 bits should not be done by writing '64' in maxpacketsize, but '3'.
While fixing this problem it turned out that there is more wrong here in this
code it turned out that the wrong bits were checked to determine if the pipe
was of type PIPE_INTERRUPT. This series fixes those errors also.

I made it 2 seperate patches. The 1st of this series is fully tested and correct
on at least the AT91SAM9261 cores. I hope it fixes the known problems on
AT91SAM9263 (and other) cores also, maybe Stelian can verify this.
If it does not help on sam9263, it should not make it worse either...

The 2nd patch, however, is created by search-for-the-same-errors-and-replace.
I am not able to test that patch, I do not have the boards, so that needs to be
done by others or by review. It is clear that code there is buggy in the
first place.

These patches require my previous series called
'Improve stability USB memory sticks for the common OHCI USB layer.' to be
applied before this series. So they should apply on the u-boot-usb git tree.
--> git://git.denx.de/u-boot-usb.git

I want to mention also, that everytime I look deeper into this code, I find new
bugs. It appears that several parts of this code is written with interrupt
handling in mind, while we have no interrupt handling at all.
Assumptions are done that a interrupt handler does things asynchronous, causing
long loops that have no real use at all...
So, no guarantees that _all_ problems are solved by now...


Kind Regards,

Remy

-- 

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2008-10-10  8:33 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-08  8:54 [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes Remy Bohmer
2008-10-08  8:54 ` [U-Boot] [patch 1/2] fix USB initialisation procedure Remy Bohmer
2008-10-09 12:10   ` Jean-Christophe PLAGNIOL-VILLARD
2008-10-09 13:19     ` Wolfgang Denk
2008-10-09 14:43       ` Markus Klotzbücher
2008-10-09 14:59         ` Stefan Roese
2008-10-09 15:09           ` Markus Klotzbücher
2008-10-09 15:22           ` Jerry Van Baren
2008-10-09 18:45           ` Wolfgang Denk
2008-10-09 19:52             ` Markus Klotzbücher
2008-10-10  7:30             ` Remy Bohmer
2008-10-09 18:42         ` Wolfgang Denk
2008-10-08  8:54 ` [U-Boot] [patch 2/2] The PIPE_INTERRUPT flag is used wrong Remy Bohmer
2008-10-08 10:12 ` [U-Boot] [patch 0/2] Some more USB-OHCI bugfixes Markus Klotzbücher
2008-10-08 10:41 ` Stelian Pop
2008-10-09  8:33 ` Stelian Pop
2008-10-09  9:51   ` Remy Bohmer
2008-10-09 15:01     ` Stelian Pop
2008-10-10  7:21       ` Remy Bohmer
2008-10-10  8:25         ` Stelian Pop
2008-10-10  8:33           ` Remy Bohmer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox