public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [U-Boot-Users] [PATCH] cmd_spi: remove broken signed casting for display
       [not found] <1223982278-28497-1-git-send-email-vapier@gentoo.org>
@ 2008-10-14 12:20 ` Wolfgang Denk
  0 siblings, 0 replies; only message in thread
From: Wolfgang Denk @ 2008-10-14 12:20 UTC (permalink / raw)
  To: u-boot

Dear Mike Frysinger,

In message <1223982278-28497-1-git-send-email-vapier@gentoo.org> you wrote:
> Since we're working with unsigned data, you can't apply a signed pointer
> cast and then attempt to print the result.  Otherwise you get wrong output
> when the sign bit is set like "0xFF" incorrectly extended to "0xFFFFFFFF".
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  common/cmd_spi.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Where a calculator on the ENIAC is equipped with 18,000 vacuum  tubes
and  weighs  30  tons,  computers  in  the future may have only 1,000
vacuum tubes and weigh only 1/2 tons. - Popular Mechanics, March 1949

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-10-14 12:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1223982278-28497-1-git-send-email-vapier@gentoo.org>
2008-10-14 12:20 ` [U-Boot] [U-Boot-Users] [PATCH] cmd_spi: remove broken signed casting for display Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox