From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 14 Oct 2008 14:20:35 +0200 Subject: [U-Boot] [U-Boot-Users] [PATCH] cmd_spi: remove broken signed casting for display In-Reply-To: <1223982278-28497-1-git-send-email-vapier@gentoo.org> References: <1223982278-28497-1-git-send-email-vapier@gentoo.org> Message-ID: <20081014122035.2DB1981C99C9@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, In message <1223982278-28497-1-git-send-email-vapier@gentoo.org> you wrote: > Since we're working with unsigned data, you can't apply a signed pointer > cast and then attempt to print the result. Otherwise you get wrong output > when the sign bit is set like "0xFF" incorrectly extended to "0xFFFFFFFF". > > Signed-off-by: Mike Frysinger > --- > common/cmd_spi.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Where a calculator on the ENIAC is equipped with 18,000 vacuum tubes and weighs 30 tons, computers in the future may have only 1,000 vacuum tubes and weigh only 1/2 tons. - Popular Mechanics, March 1949