public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] I2C: Fix CodingStyle issues in soft_i2c.c
Date: Tue, 14 Oct 2008 18:25:44 +0200	[thread overview]
Message-ID: <20081014162544.ABEAF81C99CD@gemini.denx.de> (raw)
In-Reply-To: <48E08A58.5060000@denx.de>

Dear Heiko,

In message <48E08A58.5060000@denx.de> you wrote:
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>  drivers/i2c/soft_i2c.c |   24 ++++++++++++------------
...
> +#if defined(CONFIG_8xx) && !defined(CONFIG_MGSUVD)
>  	volatile immap_t *immr = (immap_t *)CFG_IMMR;
>  #endif

I cannot find any feedback from you fro my comment about this
non-coding style change. We don't want to add such  board specific
code in global files.

Can you please update and resubmit this patch? Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Es gibt immer genug fuer die Beduerfnisse aller, aber  niemals  genug
fuer die Gier einzelner.                                    -- Ghandi

      parent reply	other threads:[~2008-10-14 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29  7:57 [U-Boot] [PATCH] I2C: Fix CodingStyle issues in soft_i2c.c Heiko Schocher
2008-09-29  9:12 ` Wolfgang Denk
2008-10-14 16:25 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081014162544.ABEAF81C99CD@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox