From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gary Jennejohn Date: Mon, 20 Oct 2008 18:26:35 +0200 Subject: [U-Boot] [PATCH 2/2 V2] IOMUX: Add console multiplexing support. In-Reply-To: <20081020155732.2653f2d7@ernst.jennejohn.org> References: <20080914164530.0a59c6ca@peedub.jennejohn.org> <20081020135849.371fe4d1@ernst.jennejohn.org> <20081020132453.DC51B835697A@gemini.denx.de> <20081020155732.2653f2d7@ernst.jennejohn.org> Message-ID: <20081020182635.4ed9ca48@ernst.jennejohn.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 20 Oct 2008 15:57:32 +0200 Gary Jennejohn wrote: > On Mon, 20 Oct 2008 15:24:53 +0200 > Wolfgang Denk wrote: > > > I have to admit that I don't like the idea of splitting the > > GD_FLG_DEVINIT into several, unrelated parts of the code. > > > > I don't like it too much myself, but it seemed like the logical approach > to me at the time I made this modification. > > > Would it not make more sense to have the netconsole part wait with > > output until it's been initialized? And/or move the netweork init to > > an earlier point, when netconsole is enabled? > > > > Not a bad idea. I think it would be most logical to do it in the > netconsole code, rather than moving up the network initialization. > > I'll take a look at that. > I looked at this some more. eth_initialize() is called in every architecture-specific library which means changing 8 files to move it up to before the initialization of netconsole. netconsole is intialized in devices_init() which is called even before console_init_r() and long before eth_initialize(). What's the opinion of the ML? Is it worth all the repository churn to move eth_initialize() up rather than changing just two files? One alrernative which occurs to me would be to introduce a new flag GD_FLG_ETHINIT, but this is even worse because it requires modifying 12 header files and 3 or more C files. --- Gary Jennejohn ********************************************************************* DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de *********************************************************************