public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every	compile
Date: Tue, 21 Oct 2008 16:57:05 +0200	[thread overview]
Message-ID: <200810211657.06019.sr@denx.de> (raw)
In-Reply-To: <1224600029.18428.339.camel@localhost.localdomain>

On Tuesday 21 October 2008, Peter Tyser wrote:
> > Why would that be confusing? It seems natural to me that time changes
> > when  you  do  several  things  sequentially.   If   a   board   used
> > __TIME__/__DATE__   in   more  than  one  location,  then  the  board
> > maintainer either did this intentionally (and thus wants to  acchieve
> > this  result),  or  he  did  it without thinking, in which case it is
> > obviously not an important issue to him).
>
> I agree that its not an important issue, but that's not to say it
> hasn't/won't confused customers/developers.  eg the first time I noticed
> it, it fooled me into thinking my flash wasn't properly programmed after
> updating u-boot.

Happend to me a few times as well. So I like your patch.

> > > the build time were printed in common/lcd.c, it would not be identical
> > > to the time printed on the serial port since lcd.c was not compiled at
> > > the same time as cpu/mpc8xx/start.S.
> >
> > If you care about reliable version information, use the git based ID
> > strings.
>
> I use git, but its version strings only change when commits occur.  I
> think having an accurate build time stamp would be a nice feature.
> FWIW, Linux handles this "issue" very similarly to my proposed solution
> so that it can have its pretty banner.  It even takes it a step further
> and gives a specific compile number (#15):
>
> Linux version 2.6.23.17 (ptyser at ptyser) (gcc version 4.3.1
> (crosstool-NG-xes) ) #15 SMP Wed Aug 6 11:45:55 CDT 2008
>
>
> I know this patch isn't a big deal, but I think it would be a valuable
> change.  If others don't agree I'll drop the issue.

As mentioned above, I think your patch is an improvement. So why not accept 
it?

Acked-by: Stefan Roese <sr@denx.de>

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  parent reply	other threads:[~2008-10-21 14:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17 22:51 [U-Boot] [PATCH][RFC] Update U-Boot's build timestamp on every compile Peter Tyser
2008-10-17 22:55 ` Peter Tyser
2008-10-21  0:59 ` Kim Phillips
2008-10-21  2:02   ` Peter Tyser
2008-10-21  7:04     ` Wolfgang Denk
2008-10-21 14:40       ` Peter Tyser
2008-10-21 14:51         ` Jerry Van Baren
2008-10-21 15:02           ` Wolfgang Denk
2008-10-21 15:17             ` Peter Tyser
2008-10-21 14:57         ` Stefan Roese [this message]
2008-10-21 15:04           ` Wolfgang Denk
2008-10-21 14:59         ` Wolfgang Denk
2008-10-21 18:52           ` Andy Fleming
2008-10-21 19:03             ` Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810211657.06019.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox