public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] improved strmhz()
Date: Wed, 22 Oct 2008 09:03:18 +0200	[thread overview]
Message-ID: <200810220903.18271.sr@denx.de> (raw)
In-Reply-To: <20081021191554.4F60F835694E@gemini.denx.de>

Hi Wolfgang,

On Tuesday 21 October 2008, Wolfgang Denk wrote:
> > > --- a/lib_generic/strmhz.c
> > > +++ b/lib_generic/strmhz.c
> > > @@ -27,7 +27,7 @@ char *strmhz (char *buf, long hz)
> > > 	long l, n;
> > > 	long m;
> > >
> > > -	n = DIV_ROUND(hz, 1000000L);
> > > +	n = DIV_ROUND(hz, 1000) / 1000L;
> > > 	l = sprintf (buf, "%ld", n);
> > >
> > > 	hz -= n * 1000000L;

<snip>

> Can you please provide the input to the strmhz() function  (the  "hz"
> parameter) that is causing such output?

This patch fixes a problem I have seen on the 1.066GHz Canyonlands. Without it 
I see this:

CPU:   AMCC PowerPC 460EX Rev. A at 1067.4294966964 MHz

with it it's this:

CPU:   AMCC PowerPC 460EX Rev. A at 1066.667 MHz

Wolfgang, can you check in the new patch version?

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2008-10-22  7:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-21 12:44 [U-Boot] [PATCH] improved strmhz() Ilko Iliev
2008-10-21 13:55 ` Wolfgang Denk
2008-10-21 14:11   ` Ilko Iliev
2008-10-21 16:54   ` Kumar Gala
2008-10-21 17:07     ` Jerry Van Baren
2008-10-21 17:38     ` Mike Frysinger
2008-10-21 19:15     ` Wolfgang Denk
2008-10-22  7:03       ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810220903.18271.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox