[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[Georg Schardt]

From: schardt <schardt@team-ctech.de>

this patch adds support for the avnet fx12 minimodul
it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo

<v2>
rebased to ppc4xx/master

Signed-off-by: schardt <schardt@team-ctech.de>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
---
 MAINTAINERS                      |    4 +
 MAKEALL                          |    1 +
 Makefile                         |   18 +++++
 board/avnet/fx12mm/.gitignore    |    1 +
 board/avnet/fx12mm/Makefile      |   27 +++++++
 board/avnet/fx12mm/config.mk     |   26 +++++++
 board/avnet/fx12mm/fx12mm.c      |   52 +++++++++++++
 board/avnet/fx12mm/init.S        |   32 ++++++++
 board/avnet/fx12mm/u-boot.lds    |  149 ++++++++++++++++++++++++++++++++++++++
 board/avnet/fx12mm/xparameters.h |   51 +++++++++++++
 include/configs/fx12mm.h         |   72 ++++++++++++++++++
 11 files changed, 433 insertions(+), 0 deletions(-)
 create mode 100644 board/avnet/fx12mm/.gitignore
 create mode 100644 board/avnet/fx12mm/Makefile
 create mode 100644 board/avnet/fx12mm/config.mk
 create mode 100644 board/avnet/fx12mm/fx12mm.c
 create mode 100644 board/avnet/fx12mm/init.S
 create mode 100644 board/avnet/fx12mm/u-boot.lds
 create mode 100644 board/avnet/fx12mm/xparameters.h
 create mode 100644 include/configs/fx12mm.h

diff --git a/MAINTAINERS b/MAINTAINERS
index a5d1038..260c3e6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -366,6 +366,10 @@ Travis Sawyer (travis.sawyer at sandburst.com>
 	METROBOX	PPC440GX
 	XPEDITE1K	PPC440GX
 
+Georg Schardt <schardt@team-ctech.de>
+
+	fx12mm		PPC405
+
 Heiko Schocher <hs@denx.de>
 
 	ids8247		MPC8247
diff --git a/MAKEALL b/MAKEALL
index aa602b7..1f56ac5 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -186,6 +186,7 @@ LIST_4xx="		\
 	ebony		\
 	ERIC		\
 	EXBITGEN	\
+	fx12mm		\
 	G2000		\
 	glacier		\
 	haleakala	\
diff --git a/Makefile b/Makefile
index 66922eb..d6abb4d 100644
--- a/Makefile
+++ b/Makefile
@@ -1293,6 +1293,24 @@ ERIC_config:	unconfig
 EXBITGEN_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx exbitgen
 
+fx12mm_flash_config: unconfig
+	@mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic
+	@mkdir -p $(obj)include $(obj)board/avnet/fx12mm
+	@echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-rom.lds"\
+		> $(obj)board/avnet/fx12mm/config.tmp
+	@echo "TEXT_BASE := 0xFFCB0000" \
+		>> $(obj)board/avnet/fx12mm/config.tmp
+	@$(MKCONFIG) fx12mm ppc ppc4xx fx12mm avnet
+
+fx12mm_config: unconfig
+	@mkdir -p $(obj)include $(obj)board/xilinx/ppc405-generic
+	@mkdir -p $(obj)include $(obj)board/avnet/fx12mm
+	@echo "LDSCRIPT:=$(SRCTREE)/board/xilinx/ppc405-generic/u-boot-ram.lds"\
+		> $(obj)board/avnet/fx12mm/config.tmp
+	@echo "TEXT_BASE := 0x03000000" \
+		>> $(obj)board/avnet/fx12mm/config.tmp
+	@$(MKCONFIG) fx12mm ppc ppc4xx fx12mm avnet
+
 G2000_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) ppc ppc4xx g2000
 
diff --git a/board/avnet/fx12mm/.gitignore b/board/avnet/fx12mm/.gitignore
new file mode 100644
index 0000000..b644f59
--- /dev/null
+++ b/board/avnet/fx12mm/.gitignore
@@ -0,0 +1 @@
+config.tmp
diff --git a/board/avnet/fx12mm/Makefile b/board/avnet/fx12mm/Makefile
new file mode 100644
index 0000000..f943781
--- /dev/null
+++ b/board/avnet/fx12mm/Makefile
@@ -0,0 +1,27 @@
+#
+# (C) Copyright 2008
+# Ricardo Ribalda,Universidad Autonoma de Madrid, ricardo.ribalda at uam.es
+# This work has been supported by: Qtechnology http://qtec.com/
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+COBJS	+= $(BOARD).o
+
+include $(SRCTREE)/board/xilinx/ppc405-generic/Makefile
diff --git a/board/avnet/fx12mm/config.mk b/board/avnet/fx12mm/config.mk
new file mode 100644
index 0000000..f5a6039
--- /dev/null
+++ b/board/avnet/fx12mm/config.mk
@@ -0,0 +1,26 @@
+#
+# (C) Copyright 2008
+# Ricardo Ribalda-Universidad Autonoma de Madrid-ricardo.ribalda at uam.es
+# Work supported by Qtechnology http://www.qtec.com
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+#
+
+sinclude $(SRCTREE)/board/xilinx/ppc405-generic/config.mk
diff --git a/board/avnet/fx12mm/fx12mm.c b/board/avnet/fx12mm/fx12mm.c
new file mode 100644
index 0000000..4858645
--- /dev/null
+++ b/board/avnet/fx12mm/fx12mm.c
@@ -0,0 +1,52 @@
+/*
+ * (C) Copyright 2008
+ *
+ * Author: Xilinx Inc.
+ *
+ * Modified by:
+ *  Georg Schardt <schardt@team-ctech.de>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+
+#include <config.h>
+#include <common.h>
+#include <asm/processor.h>
+
+int checkboard(void)
+{
+	char tmp[64];
+	char *s, *e;
+	int i = getenv_r("serial", tmp, sizeof(tmp));
+
+	if (i < 0) {
+		printf("Avnet Virtex4 FX12 with no serial #");
+	} else {
+		for (e = tmp; *e; ++e) {
+			if (*e == ' ')
+				break;
+		}
+		printf("Avnet Virtex4 FX12 Minimodul # ");
+		for (s = tmp; s < e; ++s)
+			putc(*s);
+	}
+	putc('\n');
+	return 0;
+}
diff --git a/board/avnet/fx12mm/init.S b/board/avnet/fx12mm/init.S
new file mode 100644
index 0000000..c05a211
--- /dev/null
+++ b/board/avnet/fx12mm/init.S
@@ -0,0 +1,32 @@
+/*
+ * (C) Copyright 2008
+ *
+ * Georg Schardt <schardt@team-ctech.de>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ */
+
+	.globl ext_bus_cntlr_init
+ext_bus_cntlr_init:
+	blr
+
+	.globl sdram_init
+sdram_init:
+	blr
diff --git a/board/avnet/fx12mm/u-boot.lds b/board/avnet/fx12mm/u-boot.lds
new file mode 100644
index 0000000..31af107
--- /dev/null
+++ b/board/avnet/fx12mm/u-boot.lds
@@ -0,0 +1,149 @@
+/*
+ * (C) Copyright 2000
+ * Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+OUTPUT_ARCH(powerpc)
+ENTRY(_start)
+SEARCH_DIR(/lib); SEARCH_DIR(/usr/lib); SEARCH_DIR(/usr/local/lib); SEARCH_DIR(/usr/local/powerpc-any-elf/lib);
+/* Do we need any of these for elf?
+   __DYNAMIC = 0;    */
+SECTIONS
+{
+  /* Read-only sections, merged into text segment: */
+  . = + SIZEOF_HEADERS;
+  .interp : { *(.interp) }
+  .hash          : { *(.hash)		}
+  .dynsym        : { *(.dynsym)		}
+  .dynstr        : { *(.dynstr)		}
+  .rel.text      : { *(.rel.text)		}
+  .rela.text     : { *(.rela.text) 	}
+  .rel.data      : { *(.rel.data)		}
+  .rela.data     : { *(.rela.data) 	}
+  .rel.rodata    : { *(.rel.rodata) 	}
+  .rela.rodata   : { *(.rela.rodata) 	}
+  .rel.got       : { *(.rel.got)		}
+  .rela.got      : { *(.rela.got)		}
+  .rel.ctors     : { *(.rel.ctors)	}
+  .rela.ctors    : { *(.rela.ctors)	}
+  .rel.dtors     : { *(.rel.dtors)	}
+  .rela.dtors    : { *(.rela.dtors)	}
+  .rel.bss       : { *(.rel.bss)		}
+  .rela.bss      : { *(.rela.bss)		}
+  .rel.plt       : { *(.rel.plt)		}
+  .rela.plt      : { *(.rela.plt)		}
+  .init          : { *(.init)	}
+  .plt : { *(.plt) }
+  .text      :
+  {
+    /* WARNING - the following is hand-optimized to fit within	*/
+    /* the sector layout of our flash chips!	XXX FIXME XXX	*/
+/*
+    cpu/ppc4xx/start.o	(.text)
+    board/xilinx/fx12mm/init.o	(.text)
+    cpu/ppc4xx/kgdb.o	(.text)
+    cpu/ppc4xx/traps.o	(.text)
+    cpu/ppc4xx/interrupts.o	(.text)
+    cpu/ppc4xx/serial.o	(.text)
+    cpu/ppc4xx/cpu_init.o	(.text)
+    cpu/ppc4xx/speed.o	(.text)
+    cpu/ppc4xx/4xx_enet.o	(.text)
+    common/dlmalloc.o	(.text)
+    lib_generic/crc32.o		(.text)
+    lib_ppc/extable.o	(.text)
+    lib_generic/zlib.o		(.text)
+*/
+/*    . = env_offset;*/
+/*    common/environment.o(.text)*/
+
+    *(.text)
+    *(.fixup)
+    *(.got1)
+  }
+  _etext = .;
+  PROVIDE (etext = .);
+  .rodata    :
+  {
+    *(.rodata)
+    *(.rodata1)
+    *(.rodata.str1.4)
+    *(.eh_frame)
+  }
+  .fini      : { *(.fini)    } =0
+  .ctors     : { *(.ctors)   }
+  .dtors     : { *(.dtors)   }
+
+  /* Read-write section, merged into data segment: */
+  . = (. + 0x00FF) & 0xFFFFFF00;
+  _erotext = .;
+  PROVIDE (erotext = .);
+  .reloc   :
+  {
+    *(.got)
+    _GOT2_TABLE_ = .;
+    *(.got2)
+    _FIXUP_TABLE_ = .;
+    *(.fixup)
+  }
+  __got2_entries = (_FIXUP_TABLE_ - _GOT2_TABLE_) >>2;
+  __fixup_entries = (. - _FIXUP_TABLE_)>>2;
+
+  .data    :
+  {
+    *(.data)
+    *(.data1)
+    *(.sdata)
+    *(.sdata2)
+    *(.dynamic)
+    CONSTRUCTORS
+  }
+  _edata  =  .;
+  PROVIDE (edata = .);
+
+  . = .;
+  __u_boot_cmd_start = .;
+  .u_boot_cmd : { *(.u_boot_cmd) }
+  __u_boot_cmd_end = .;
+
+
+  . = .;
+  __start___ex_table = .;
+  __ex_table : { *(__ex_table) }
+  __stop___ex_table = .;
+
+  . = ALIGN(256);
+  __init_begin = .;
+  .text.init : { *(.text.init) }
+  .data.init : { *(.data.init) }
+  . = ALIGN(256);
+  __init_end = .;
+
+  __bss_start = .;
+  .bss       :
+  {
+   *(.sbss) *(.scommon)
+   *(.dynbss)
+   *(.bss)
+   *(COMMON)
+  }
+  _end = . ;
+  PROVIDE (end = .);
+}
diff --git a/board/avnet/fx12mm/xparameters.h b/board/avnet/fx12mm/xparameters.h
new file mode 100644
index 0000000..f7031b3
--- /dev/null
+++ b/board/avnet/fx12mm/xparameters.h
@@ -0,0 +1,51 @@
+/*
+ * (C) Copyright 2008
+ *
+ * Georg Schardt <schardt@team-ctech.de>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ * CAUTION: This file is based on the xparameters.h automatically
+ * generated by libgen. Version: Xilinx EDK 10.1.02 Build EDK_K_SP2.5
+ */
+
+#ifndef __XPARAMETER_H__
+#define __XPARAMETER_H__
+
+/* RS232 */
+#define XPAR_UARTNS550_0_CLOCK_FREQ_HZ 100000000
+#define XPAR_UARTNS550_0_BASEADDR 0x83E00000
+
+
+/* INT_C */
+#define XPAR_XPS_INTC_0_DEVICE_ID 0
+#define XPAR_XPS_INTC_0_BASEADDR 0x81800000
+#define XPAR_INTC_MAX_NUM_INTR_INPUTS 2
+
+/* CPU core clock */
+#define XPAR_CORE_CLOCK_FREQ_HZ 300000000
+#define XPAR_PLB_CLOCK_FREQ_HZ  100000000
+
+/* RAM */
+#define XPAR_DDR2_SDRAM_MEM_BASEADDR 0x00000000
+
+/* FLASH */
+#define XPAR_FLASH_2MX16_MEM0_BASEADDR 0xFFC00000
+
+#endif
diff --git a/include/configs/fx12mm.h b/include/configs/fx12mm.h
new file mode 100644
index 0000000..d45e7a0
--- /dev/null
+++ b/include/configs/fx12mm.h
@@ -0,0 +1,72 @@
+/*
+ * (C) Copyright 2008
+ *
+ * Ricado Ribalda-Universidad Autonoma de Madrid-ricardo.ribalda at uam.es
+ * This work has been supported by: QTechnology  http://qtec.com
+ *
+ * Georg Schardt <schardt@team-ctech.de>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+
+/*
+   Configuration file for the Virtex4FX12 Minimodul by Avnet/Memec,
+   see http://www.em.avnet.com
+*/
+
+#ifndef __CONFIG_FX12_H
+#define __CONFIG_FX12_H
+
+#include "../board/avnet/fx12mm/xparameters.h"
+
+/* cmd config */
+#define CONFIG_CMD_JFFS2
+#define CONFIG_JFFS2_CMDLINE
+#undef CONFIG_CMD_NET
+
+/* sdram */
+#define CONFIG_SYS_SDRAM_SIZE_MB       64
+
+/* environment */
+#define CONFIG_ENV_IS_IN_FLASH  1
+#define CONFIG_ENV_SIZE         0x10000
+#define CONFIG_ENV_SECT_SIZE    0x10000
+#define CONFIG_SYS_ENV_OFFSET   0xA0000
+#define CONFIG_ENV_ADDR         (CONFIG_SYS_FLASH_BASE+CONFIG_SYS_ENV_OFFSET)
+#define CONFIG_ENV_OVERWRITE 	1
+
+/*Misc*/
+#define CONFIG_SYS_PROMPT	"FX12MM:/# " /* Monitor Command Prompt */
+#define CONFIG_PREBOOT      	"echo U-Boot is up and runnining;"
+
+/*Flash*/
+#define CONFIG_SYS_FLASH_BASE          XPAR_FLASH_2MX16_MEM0_BASEADDR
+#define CONFIG_SYS_FLASH_SIZE          (4*1024*1024)
+#define CONFIG_SYS_MAX_FLASH_SECT      71
+#define CONFIG_SYS_FLASH_CFI		1
+#define CONFIG_FLASH_CFI_DRIVER		1
+#define MTDIDS_DEFAULT		"nor0=fx12mm-flash"
+#define MTDPARTS_DEFAULT	"mtdparts=fx12mm-flash:-(user)"
+
+
+#include "configs/xilinx-ppc405.h"
+
+#endif                          /* __CONFIG_H */
+
-- 
1.5.4.1

[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[Stefan Roese]

On Wednesday 22 October 2008, Georg Schardt wrote:
> From: schardt <schardt@team-ctech.de>
>
> this patch adds support for the avnet fx12 minimodul
> it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from
> Ricardo
>
> <v2>
> rebased to ppc4xx/master

Thanks. Another comment below.

> Signed-off-by: schardt <schardt@team-ctech.de>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
> ---
>  MAINTAINERS                      |    4 +
>  MAKEALL                          |    1 +
>  Makefile                         |   18 +++++
>  board/avnet/fx12mm/.gitignore    |    1 +
>  board/avnet/fx12mm/Makefile      |   27 +++++++
>  board/avnet/fx12mm/config.mk     |   26 +++++++
>  board/avnet/fx12mm/fx12mm.c      |   52 +++++++++++++
>  board/avnet/fx12mm/init.S        |   32 ++++++++
>  board/avnet/fx12mm/u-boot.lds    |  149
> ++++++++++++++++++++++++++++++++++++++ board/avnet/fx12mm/xparameters.h |  
> 51 +++++++++++++
>  include/configs/fx12mm.h         |   72 ++++++++++++++++++
>  11 files changed, 433 insertions(+), 0 deletions(-)
>  create mode 100644 board/avnet/fx12mm/.gitignore
>  create mode 100644 board/avnet/fx12mm/Makefile
>  create mode 100644 board/avnet/fx12mm/config.mk
>  create mode 100644 board/avnet/fx12mm/fx12mm.c
>  create mode 100644 board/avnet/fx12mm/init.S
>  create mode 100644 board/avnet/fx12mm/u-boot.lds
>  create mode 100644 board/avnet/fx12mm/xparameters.h
>  create mode 100644 include/configs/fx12mm.h

<snip>

> diff --git a/board/avnet/fx12mm/init.S b/board/avnet/fx12mm/init.S
> new file mode 100644
> index 0000000..c05a211
> --- /dev/null
> +++ b/board/avnet/fx12mm/init.S
> @@ -0,0 +1,32 @@
> +/*
> + * (C) Copyright 2008
> + *
> + * Georg Schardt <schardt@team-ctech.de>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + *
> + */
> +
> +	.globl ext_bus_cntlr_init
> +ext_bus_cntlr_init:
> +	blr
> +
> +	.globl sdram_init
> +sdram_init:
> +	blr

This file is not needed anymore. Please remove it.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[Jerry Van Baren]

Georg Schardt wrote:
> From: schardt <schardt@team-ctech.de>
> 
> this patch adds support for the avnet fx12 minimodul
> it needs the "ppc4xx: Generic architecture for xilinx ppc405" patch from Ricardo
> 
> <v2>
> rebased to ppc4xx/master

The above two^Wfour lines should go *below* the "---", they are remarks 
WRT the patch, not really a commit comment for posterity.  Ahh, also the 
line "it needs the "ppc4xx: Generic architecture for xilinx ppc405" 
patch from Ricardo" should go below the "---".

Also, s/minimodul/minimodule/ unless it really *is* spelled w/o the "e".

While we are critiquing the English, sentences start with capital 
letters and end with periods, as in "This patch adds support for the 
avnet fx12 minimodule."

WRT the subject line, the <v2> should go *inside* the [PATCH v2] so it 
doesn't get included in the git repository comment.

> Signed-off-by: schardt <schardt@team-ctech.de>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@uam.es>
> ---

Put your remarks here.

>  MAINTAINERS                      |    4 +
>  MAKEALL                          |    1 +
>  Makefile                         |   18 +++++
>  board/avnet/fx12mm/.gitignore    |    1 +
>  board/avnet/fx12mm/Makefile      |   27 +++++++
>  board/avnet/fx12mm/config.mk     |   26 +++++++
>  board/avnet/fx12mm/fx12mm.c      |   52 +++++++++++++
>  board/avnet/fx12mm/init.S        |   32 ++++++++
>  board/avnet/fx12mm/u-boot.lds    |  149 ++++++++++++++++++++++++++++++++++++++
>  board/avnet/fx12mm/xparameters.h |   51 +++++++++++++
>  include/configs/fx12mm.h         |   72 ++++++++++++++++++

[snip]

The bike shed is blue today.

Thanks,
gvb

[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[Georg Schardt]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
Hi Jerry,

thx for your comments, i will pay attention on the right patch format
the next time. It is my first project I send patches to and until now,
git is not my best friend.

Sorry for my poor english, it is not my native  language and i dont
know that this is a problem here.

Georg

Jerry Van Baren schrieb:
> Georg Schardt wrote:
>> From: schardt <schardt@team-ctech.de>
>>
>> this patch adds support for the avnet fx12 minimodul it needs the
>> "ppc4xx: Generic architecture for xilinx ppc405" patch from
>> Ricardo
>>
>> <v2> rebased to ppc4xx/master
>
> The above two^Wfour lines should go *below* the "---", they are
> remarks WRT the patch, not really a commit comment for posterity.
> Ahh, also the line "it needs the "ppc4xx: Generic architecture for
> xilinx ppc405" patch from Ricardo" should go below the "---".
>
> Also, s/minimodul/minimodule/ unless it really *is* spelled w/o the
>  "e".
>
> While we are critiquing the English, sentences start with capital
> letters and end with periods, as in "This patch adds support for
> the avnet fx12 minimodule."
>
> WRT the subject line, the <v2> should go *inside* the [PATCH v2] so
>  it doesn't get included in the git repository comment.
>
>> Signed-off-by: schardt <schardt@team-ctech.de> Signed-off-by:
>> Ricardo Ribalda Delgado <ricardo.ribalda@uam.es> ---
>
> Put your remarks here.
>
>> MAINTAINERS                      |    4 + MAKEALL
>> |    1 + Makefile                         |   18 +++++
>> board/avnet/fx12mm/.gitignore    |    1 +
>> board/avnet/fx12mm/Makefile      |   27 +++++++
>> board/avnet/fx12mm/config.mk     |   26 +++++++
>> board/avnet/fx12mm/fx12mm.c      |   52 +++++++++++++
>> board/avnet/fx12mm/init.S        |   32 ++++++++
>> board/avnet/fx12mm/u-boot.lds    |  149
>> ++++++++++++++++++++++++++++++++++++++
>> board/avnet/fx12mm/xparameters.h |   51 +++++++++++++
>> include/configs/fx12mm.h         |   72 ++++++++++++++++++
>
> [snip]
>
> The bike shed is blue today.
>
> Thanks, gvb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
iEYEARECAAYFAkj/Hl0ACgkQUicxT/v10ZuYQwCdFQ4wFp4N2lyeTy01PPpEHnjd
kGgAniHDR2OxkXkbljMi/EU+5vKvVK9p
=n6XX
-----END PGP SIGNATURE-----

[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[Jerry Van Baren]

Georg Schardt wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>  
> Hi Jerry,
> 
> thx for your comments, i will pay attention on the right patch format
> the next time. It is my first project I send patches to and until now,
> git is not my best friend.

Oh, but it will be.  ;-)  Git and open source development is optimized 
for getting something done and relying on the rest of the world (list) 
to critique the changes to get things done "right."  Note that this 
isn't just mentoring, it goes beyond correcting minor mistakes and 
becomes that magic known as *collaboration.*

In my day job, our change control system is optimized to get things done 
"right": it spends an enormous amount of energy (and money) to prevent 
anything "wrong" from being done.  While this is intuitive and appeals 
to the PHBs, the actual effect is that the change management system is 
optimized to *prevent* change.  If nothing changes, nothing will break 
(worse), therefore it is "optimal," assuming the proper definition of 
"optimal."  Aaargh!

> Sorry for my poor english, it is not my native  language and i dont
> know that this is a problem here.

To my shame, your English is a far cry better than my German, so you 
have nothing to apologize for there.

Your English isn't a big problem.  I mainly threw it in because I was 
critiquing other stuff.  OTOH, if nobody corrects errors (English, 
comments, content), nobody would learn how to do things better.

> Georg

Best regards,
gvb

[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[Stefan Roese]

Georg,

On Wednesday 22 October 2008, Georg Schardt wrote:
> thx for your comments, i will pay attention on the right patch format
> the next time. It is my first project I send patches to and until now,
> git is not my best friend.

Do you plan to send an updated patch version soon?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[Georg Schardt]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 

Sorry, i was very busy on my dayjob this week. I will send a new patch
this evening.

Georg

Stefan Roese schrieb:
> Georg,
>
> On Wednesday 22 October 2008, Georg Schardt wrote:
>> thx for your comments, i will pay attention on the right patch
>> format the next time. It is my first project I send patches to
>> and until now, git is not my best friend.
>
> Do you plan to send an updated patch version soon?
>
> Best regards, Stefan
>
> =====================================================================
>  DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev
> Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194
> Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80
> Email: office at denx.de
> =====================================================================
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
iEYEARECAAYFAkkBrAoACgkQUicxT/v10ZvJLQCfQLB2hjc9vw+XMT6cIGygh2Rx
sBgAnjBq2LT9elQo2WvJPEWDEbIuUAk+
=T00n
-----END PGP SIGNATURE-----

[U-Boot] [PATCH] ppc4xx: New board avnet fx12 minimodule <v2>

[Stefan Roese]

On Friday 24 October 2008, Georg Schardt wrote:
> Sorry, i was very busy on my dayjob this week. I will send a new patch
> this evening.

No need to apologize. I was just checking that I didn't miss anything.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================