[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Ilko Iliev]

This patch fix the problem that only the [NB_DATAFLASH_AREA -1] dataflash partition can be defined to use the area to the end of dataflash size.
Now it is possible to have only one dataflash partition from 0 to the end of of dataflash size.

Signed-off-by: Ilko Iliev <iliev@ronetix.at>
---
 drivers/mtd/dataflash.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c
index 201e518..43746e7 100644
--- a/drivers/mtd/dataflash.c
+++ b/drivers/mtd/dataflash.c
@@ -131,7 +131,7 @@ int AT91F_DataflashInit (void)
 			break;
 		}
 		/* set the last area end to the dataflash size*/
-		area_list[NB_DATAFLASH_AREA -1].end =
+		dataflash_info[i].end_address = 
 				(dataflash_info[i].Device.pages_number *
 				dataflash_info[i].Device.pages_size)-1;
 
@@ -146,7 +146,7 @@ int AT91F_DataflashInit (void)
 				if(area_list[part].end == 0xffffffff) {
 					dataflash_info[i].Device.area_list[j].end =
 						dataflash_info[i].end_address +
-						dataflash_info	[i].logical_address;
+						dataflash_info[i].logical_address;
 					last_part = 1;
 				} else {
 					dataflash_info[i].Device.area_list[j].end =
-- 
1.5.2.2

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Jean-Christophe PLAGNIOL-VILLARD]

On 16:41 Mon 27 Oct     , Ilko Iliev wrote:
> This patch fix the problem that only the [NB_DATAFLASH_AREA -1] dataflash partition can be defined to use the area to the end of dataflash size.
> Now it is possible to have only one dataflash partition from 0 to the end of of dataflash size.
> 
> Signed-off-by: Ilko Iliev <iliev@ronetix.at>
> ---
>  drivers/mtd/dataflash.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c
> index 201e518..43746e7 100644
> --- a/drivers/mtd/dataflash.c
> +++ b/drivers/mtd/dataflash.c
Who is supposed to handle this one?

Stefan is it you?

Best Regards,
J.

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Stefan Roese]

On Tuesday 28 October 2008, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 16:41 Mon 27 Oct     , Ilko Iliev wrote:
> > This patch fix the problem that only the [NB_DATAFLASH_AREA -1] dataflash
> > partition can be defined to use the area to the end of dataflash size.
> > Now it is possible to have only one dataflash partition from 0 to the end
> > of of dataflash size.
> >
> > Signed-off-by: Ilko Iliev <iliev@ronetix.at>
> > ---
> >  drivers/mtd/dataflash.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c
> > index 201e518..43746e7 100644
> > --- a/drivers/mtd/dataflash.c
> > +++ b/drivers/mtd/dataflash.c
>
> Who is supposed to handle this one?
>
> Stefan is it you?

I don't feel responsible for dataflash. I think it would be best if this would 
go in via Wolfgang directly.

Wolfgang, what do you think?

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Wolfgang Denk]

Dear Stefan Roese,

In message <200810310953.44671.sr@denx.de> you wrote:
>
> > > diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c
> > > index 201e518..43746e7 100644
> > > --- a/drivers/mtd/dataflash.c
> > > +++ b/drivers/mtd/dataflash.c
> >
> > Who is supposed to handle this one?
> >
> > Stefan is it you?
> 
> I don't feel responsible for dataflash. I think it would be best if this would 
> go in via Wolfgang directly.
> 
> Wolfgang, what do you think?

I tend to use a broad view  summarizing  all  types  of  flash  based
storage  devices  (NAND,  OneNAND, Dataflash, etc.). As such, I would
see this on Scott's desk...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
C++ is the best example of second-system effect since OS/360.

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Scott Wood]

Wolfgang Denk wrote:
> In message <200810310953.44671.sr@denx.de> you wrote:
>>>> diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c
>>>> index 201e518..43746e7 100644
>>>> --- a/drivers/mtd/dataflash.c
>>>> +++ b/drivers/mtd/dataflash.c
>>> Who is supposed to handle this one?
>>>
>>> Stefan is it you?
>> I don't feel responsible for dataflash. I think it would be best if this would 
>> go in via Wolfgang directly.
>>
>> Wolfgang, what do you think?
> 
> I tend to use a broad view  summarizing  all  types  of  flash  based
> storage  devices  (NAND,  OneNAND, Dataflash, etc.). As such, I would
> see this on Scott's desk...

I barely have enough time to keep up with NAND, I know nothing about 
dataflash and have no hardware to test anything on, and there's no 
shared code.  As such, I'm not sure that there's any point in routing 
the patches through me.

-Scott

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Wolfgang Denk]

Dear Scott Wood,

In message <490B2BB1.7060705@freescale.com> you wrote:
>
> > I tend to use a broad view  summarizing  all  types  of  flash  based
> > storage  devices  (NAND,  OneNAND, Dataflash, etc.). As such, I would
> > see this on Scott's desk...
> 
> I barely have enough time to keep up with NAND, I know nothing about 
> dataflash and have no hardware to test anything on, and there's no 
> shared code.  As such, I'm not sure that there's any point in routing 
> the patches through me.

Me too.

Is there anybody around volunteering to become custodian for
Dataflash support?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bus error -- please leave by the rear door.

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Jean-Christophe PLAGNIOL-VILLARD]

On 17:05 Fri 31 Oct     , Wolfgang Denk wrote:
> Dear Scott Wood,
> 
> In message <490B2BB1.7060705@freescale.com> you wrote:
> >
> > > I tend to use a broad view  summarizing  all  types  of  flash  based
> > > storage  devices  (NAND,  OneNAND, Dataflash, etc.). As such, I would
> > > see this on Scott's desk...
> > 
> > I barely have enough time to keep up with NAND, I know nothing about 
> > dataflash and have no hardware to test anything on, and there's no 
> > shared code.  As such, I'm not sure that there's any point in routing 
> > the patches through me.
> 
> Me too.
> 
> Is there anybody around volunteering to become custodian for
> Dataflash support?
If we can keep it with AT91?

Nearly all at91 ref board had dataflash

Best Regards,
J.

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081031161926.GD30935@game.jcrosoft.org> you wrote:
>
> > Is there anybody around volunteering to become custodian for
> > Dataflash support?
> If we can keep it with AT91?
> 
> Nearly all at91 ref board had dataflash

Does that mean you want to take that duty as part of the AT91
custodianship?  In addition to al what you already have heaped on your
plate?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Administration: An ingenious abstraction  in  politics,  designed  to
receive the kicks and cuffs due to the premier or president.
- Ambrose Bierce

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20081028064043.GC6417@game.jcrosoft.org> you wrote:
>
> > This patch fix the problem that only the [NB_DATAFLASH_AREA -1] dataflash partition can be defined to use the area to the end of dataflash size.
> > Now it is possible to have only one dataflash partition from 0 to the end of of dataflash size.
> > 
> > Signed-off-by: Ilko Iliev <iliev@ronetix.at>
> > ---
> >  drivers/mtd/dataflash.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c
> > index 201e518..43746e7 100644
> > --- a/drivers/mtd/dataflash.c
> > +++ b/drivers/mtd/dataflash.c
> Who is supposed to handle this one?

Now that you claimed responsibility for  dataflash  code,  could  you
please add it and/or provide feedback to the submitter?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  Why do mountain climbers rope themselves together?
A:  To prevent the sensible ones from going home.

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Jean-Christophe PLAGNIOL-VILLARD]

On 00:22 Wed 19 Nov     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20081028064043.GC6417@game.jcrosoft.org> you wrote:
> >
> > > This patch fix the problem that only the [NB_DATAFLASH_AREA -1] dataflash partition can be defined to use the area to the end of dataflash size.
> > > Now it is possible to have only one dataflash partition from 0 to the end of of dataflash size.
> > > 
> > > Signed-off-by: Ilko Iliev <iliev@ronetix.at>
> > > ---
> > >  drivers/mtd/dataflash.c |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c
> > > index 201e518..43746e7 100644
> > > --- a/drivers/mtd/dataflash.c
> > > +++ b/drivers/mtd/dataflash.c
> > Who is supposed to handle this one?
> 
> Now that you claimed responsibility for  dataflash  code,  could  you
> please add it and/or provide feedback to the submitter?
I'll hope when can found a MMC/SD/DATAFLASH Maintainer

Best Regards,
J.

[U-Boot] [PATCH] dataflash: fix a problem with the last partition

[Jean-Christophe PLAGNIOL-VILLARD]

On 16:41 Mon 27 Oct     , Ilko Iliev wrote:
> This patch fix the problem that only the [NB_DATAFLASH_AREA -1] dataflash partition can be defined to use the area to the end of dataflash size.
> Now it is possible to have only one dataflash partition from 0 to the end of of dataflash size.
please limit to 80 Chars
> 
> Signed-off-by: Ilko Iliev <iliev@ronetix.at>
> ---
>  drivers/mtd/dataflash.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/dataflash.c b/drivers/mtd/dataflash.c
> index 201e518..43746e7 100644
> --- a/drivers/mtd/dataflash.c
> +++ b/drivers/mtd/dataflash.c
> @@ -131,7 +131,7 @@ int AT91F_DataflashInit (void)
>  			break;
>  		}
>  		/* set the last area end to the dataflash size*/
> -		area_list[NB_DATAFLASH_AREA -1].end =
> +		dataflash_info[i].end_address = 
>  				(dataflash_info[i].Device.pages_number *
>  				dataflash_info[i].Device.pages_size)-1;
>  
> @@ -146,7 +146,7 @@ int AT91F_DataflashInit (void)
>  				if(area_list[part].end == 0xffffffff) {
>  					dataflash_info[i].Device.area_list[j].end =
>  						dataflash_info[i].end_address +
> -						dataflash_info	[i].logical_address;
> +						dataflash_info[i].logical_address;
please spit in 2 one for coding style fix and one for modification
and btw maybe fix all coding style violation?
as space before and after '-' & co, etc...
>  					last_part = 1;
>  				} else {
>  					dataflash_info[i].Device.area_list[j].end =
Best Regards,
J.