From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 10 Nov 2008 17:46:51 +0100
Subject: [U-Boot] [PATCH] OneNAND: Fix compiler warnings and add weak
	attribute to memcpy_16()
In-Reply-To: <49186108.7040901@freescale.com>
References: <1226070552-30144-1-git-send-email-sr@denx.de>
	<200811080636.41027.sr@denx.de> <49186108.7040901@freescale.com>
Message-ID: <200811101746.51575.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 10 November 2008, Scott Wood wrote:
> >> Can it just override write_bufferram and read_bufferram?
> >
> > There are multiple functions here using this memcpy_16():
> >
> > onenand_read_bufferram()
> > onenand_sync_read_bufferram()
> > onenand_write_bufferram()
> >
> > So it seemed "easier" for me to just override the memcpy_16() function
> > itself.
>
> onenand_read_bufferram and onenand_sync_read_bufferram are alternatives
> for the read_bufferram method; you don't need to provide both.  Thus,
> it's two method overrides versus two weak overrides.  Unless the board
> code doesn't know which of the two types of read will be used?

Yes, you're right of course. I'll give it a try and send an updated patch (if 
needed) soon.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================