From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexey Neyman <avn@emcraft.com>
Date: Mon, 10 Nov 2008 22:49:02 -0800
Subject: [U-Boot] [PATCH/RFC] Some speed improvements to U-Boot JFFS2
	code
In-Reply-To: <491040B1.7080407@gmx.de>
References: <1223877234-720-1-git-send-email-yanok@emcraft.com>
	<49102E92.7010909@gmx.de> <491040B1.7080407@gmx.de>
Message-ID: <200811102249.02725.avn@emcraft.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Michael,

I tried to reproduce the bug you mentioned (multiple appearance of 
directories in ls output) using the script you provided, to no avail: 
ls correctly showed the top-level directory, both with and without 
CFG_JFFS2_SORT_FRAGMENTS option.

I am inclined to suspect the same cause as you mentioned below:

> Our u-boot is not placed in flash were it is located to on compilation
> time. static const char * points into flash space at some not properly
> initialized flash space.

This would affect all global and static variables, with unpredictable 
results. Could you try to reproduce this bug with u-boot placed at the 
address it was linked to?

As a side note, your fix for compilation with CFG_JFFS2_SORT_FRAGMENTS 
option turned on would be better as follows: replace

  if (pL->readbuf == NULL)
     put_fl_mem(jNode);

with

  put_fl_mem(jNode, pL->readbuf);

(put_fl_mem already performs this check)


Regards,
Alexey.