[U-Boot] [PATCH] bug fix for the delay function of ARM s3c44b0

[U-Boot] [PATCH] bug fix for the delay function of ARM s3c44b0

[Chaofu Chen]

The original implementation of delay function of ARM s3c44b0 doesnt' cooperate with U-Boot kernel well, which will cause fake-time-out. What is important is to keep timestamp in unit of millisecond. 

diff -purN old/cpu/s3c44b0/interrupts.c new/cpu/s3c44b0/interrupts.c
--- old/cpu/s3c44b0/interrupts.c	2005-12-17 00:39:27.000000000 +0800
+++ new/cpu/s3c44b0/interrupts.c	2008-11-13 20:36:46.000000000 +0800
@@ -147,7 +147,7 @@ static ulong lastdec;
 int interrupt_init (void)
 {
 	TCFG0 = 0x000000E9;
-	TCFG1 = 0x00000004;
+	TCFG1 = 0x00000040;
 	TCON = 0x00000900;
 	TCNTB1 = TIMER_LOAD_VAL;
 	TCMPB1 = 0;
@@ -185,7 +185,7 @@ void udelay (unsigned long usec)
 
 	tmo = usec / 1000;
 	tmo *= CFG_HZ;
-	tmo /= 8;
+	tmo /= 1000;
 
 	tmo += get_timer (0);
 
@@ -213,7 +213,7 @@ ulong get_timer_masked (void)
 	}
 	lastdec = now;
 
-	return timestamp;
+	return (timestamp >> 3);
 }
 
 void udelay_masked (unsigned long usec)
@@ -225,10 +225,9 @@ void udelay_masked (unsigned long usec)
 	if (usec >= 1000) {
 		tmo = usec / 1000;
 		tmo *= CFG_HZ;
-		tmo /= 8;
+		tmo /= 1000;
 	} else {
-		tmo = usec * CFG_HZ;
-		tmo /= (1000*8);
+		tmo = 1;
 	}
 
 	endtime = get_timer(0) + tmo;



      

[U-Boot] [PATCH] bug fix for the delay function of ARM s3c44b0

[Jean-Christophe PLAGNIOL-VILLARD]

On 05:11 Thu 13 Nov     , Chaofu Chen wrote:
> The original implementation of delay function of ARM s3c44b0 doesnt' cooperate with U-Boot kernel well, which will cause fake-time-out. What is important is to keep timestamp in unit of millisecond. 
> 
SOB please

> diff -purN old/cpu/s3c44b0/interrupts.c new/cpu/s3c44b0/interrupts.c
> --- old/cpu/s3c44b0/interrupts.c	2005-12-17 00:39:27.000000000 +0800
> +++ new/cpu/s3c44b0/interrupts.c	2008-11-13 20:36:46.000000000 +0800
> @@ -147,7 +147,7 @@ static ulong lastdec;
>  int interrupt_init (void)
>  {
>  	TCFG0 = 0x000000E9;
> -	TCFG1 = 0x00000004;
> +	TCFG1 = 0x00000040;
>  	TCON = 0x00000900;
>  	TCNTB1 = TIMER_LOAD_VAL;
>  	TCMPB1 = 0;
> @@ -185,7 +185,7 @@ void udelay (unsigned long usec)
>  
>  	tmo = usec / 1000;
>  	tmo *= CFG_HZ;
now it's CFG_HZ

please rebase you code against the current tree

Best Regards,
J.