From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 17 Nov 2008 09:45:38 +0100 Subject: [U-Boot] [PATCH] cfi_flash: Make all flash access functions weak In-Reply-To: <20081113091852.6dcef4cf@hskinnemo-gx745.norway.atmel.com> References: <1226493106-28429-1-git-send-email-sr@denx.de> <20081113091852.6dcef4cf@hskinnemo-gx745.norway.atmel.com> Message-ID: <200811170945.38488.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 13 November 2008, Haavard Skinnemoen wrote: > Stefan Roese wrote: > > This patch defines all flash access functions as weak so that > > they can be overridden by board specific versions. > > > > This will be used by the upcoming VCTH board support where the NOR > > FLASH unfortunately can't be accessed memory-mapped. Special > > accessor functions are needed here. > > > > Signed-off-by: Stefan Roese > > How much overhead does this add? Those things used to be trivial > inlines, but can't be if you turn them into weak aliases. Here the difference for a PPC4xx board (Kilauea): Old version without weak aliases: text data bss dec hex filename 280964 20232 50788 351984 55ef0 ./u-boot New version with weak aliases: text data bss dec hex filename 280520 20232 50788 351540 55d34 ./u-boot So the difference is 444 bytes (with gcc 4.2.2). I have to admit that this is more than I thought. If necessary I could make this weak change conditionally of course. I just didn't want to "pollute" to the source with more #ifdef's. Any comments? Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================