From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 17 Nov 2008 10:49:33 +0100
Subject: [U-Boot] [PATCH] cfi_flash: Make all flash access functions weak
In-Reply-To: <20081117104016.7f9a1b9a@hskinnemo-gx745.norway.atmel.com>
References: <1226493106-28429-1-git-send-email-sr@denx.de>
	<200811171034.03928.sr@denx.de>
	<20081117104016.7f9a1b9a@hskinnemo-gx745.norway.atmel.com>
Message-ID: <200811171049.33323.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 17 November 2008, Haavard Skinnemoen wrote:
> Stefan Roese <sr@denx.de> wrote:
> > I could do it this way, sure. But how about this version:
> >
> > static void __flash_write8(u8 value, void *addr)
> > {
> > 	__raw_writeb(value, addr);
> > }
> > ...
> >
> > #ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS
> > void flash_write8(u8 value, void *addr)__attribute__((weak,
> > alias("__flash_write8"))); ...
> > #else
> > #define flash_read8	__flash_read8
> > ...
> > #endif
> >
> > We would still have the original accessor functions this way. And the
> > resulting source code looks a little "better" to me (less #ifdef's).
>
> Hmm...1 #ifdef vs. 1 #ifdef...I'd say that's pretty much the same ;-)

Yes right. I first thought you wanted to override the functions on a 
per-function basis:

#ifndef flash_write8
# define flash_write8(value, addr)     __raw_writeb(value, addr)
#endif
#ifndef flash_write16
# define flash_write16(value, addr)     __raw_writew(value, addr)
#endif
...

> But sure, your way works too.

OK, I'll submit a new patch version later today.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================