From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 18 Nov 2008 16:56:38 +0100
Subject: [U-Boot]
	=?iso-8859-1?q?=5BPATCH=5D_MIPS=3A_Add_board=5Fearly=5Fi?=
	=?iso-8859-1?q?nit=5Ff=28=29_to=09init=5Fsequence?=
In-Reply-To: <4922D89F.5030708@ruby.dti.ne.jp>
References: <1226492282-27777-1-git-send-email-sr@denx.de>
	<20081117141419.GF9160@game.jcrosoft.org>
	<4922D89F.5030708@ruby.dti.ne.jp>
Message-ID: <200811181656.38245.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday 18 November 2008, Shinya Kuribayashi wrote:
> >> +++ b/lib_mips/board.c
> >> @@ -70,6 +70,15 @@ static ulong mem_malloc_brk;
> >>   */
> >>  unsigned long mips_io_port_base = -1;
> >>
> >> +int __board_early_init_f(void)
> >> +{
> >> +	/*
> >> +	 * Nothing to do in this dummy implementation
> >> +	 */
> >> +	return 0;
> >> +}
> >
> > why not remove this and create a generic dummy function
> > to reduce to code size impact
>
> +1.  Such dummy function could be shared among all architectures.

OK, makes perfect sense. We would need different dummy functions for each 
different parameter though, such as:

void dummy_void_void(void);
int dummy_int_void(void);
int dummy_int_int(int);
int dummy_int_pint(* int);
...

And where should those functions be placed? We could create a new file 
probably in lib_generic for this. I suggest we postpone this consolidation 
until after the next release though.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================