public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH-OMAP3 v2] OMAP3: Fix gpmc_cs_base pointer math	in NAND
Date: Wed, 19 Nov 2008 09:45:07 +0100	[thread overview]
Message-ID: <20081119084507.GA9198@game.jcrosoft.org> (raw)
In-Reply-To: <49189255.0c58560a.40c1.fffff5a1@mx.google.com>

On 20:58 Mon 10 Nov     , dirk.behme at googlemail.com wrote:
> gpmc_cs_base is an uint32_t pointer, correct pointer math. Missed after
> readl/writel conversion.
> 
> Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
> 
> ---
> 
> Changes in v2:
> 
> - Correct patch header style.
> 
> v2 of this patch makes previous version v1 obsolete.
> 
> Jean-Christophe: Would be nice if you could handle this patch with priority
> as it prevents BeagleBoard from starting. Thanks!
> 
>  drivers/mtd/nand/omap_gpmc.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 

I've try to apply it but

OMAP3: Fix error in gpmc_init

Fix error in gpmc_init() introduced with readl/writel conversion. Use base
addresses + offset, not offset only. Minor clean up by removing unused code.

Signed-off-by: Dirk Behme <dirk.behme@gmail.com>
--------------------------
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying OMAP3: Fix error in gpmc_init
error: patch failed: cpu/arm_cortexa8/omap3/mem.c:233
error: cpu/arm_cortexa8/omap3/mem.c: patch does not apply
fatal: sha1 information is lacking or useless (cpu/arm_cortexa8/omap3/mem.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0003.
When you have resolved this problem run "git-am -i -3 --resolved".
If you would prefer to skip this patch, instead run "git-am -i -3 --skip".

could you rebase it and specify the patch apply order via [PATCH X/X]

Best Regards,
J.

      reply	other threads:[~2008-11-19  8:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-10 19:58 [U-Boot] [PATCH-OMAP3 v2] OMAP3: Fix gpmc_cs_base pointer math in NAND dirk.behme at googlemail.com
2008-11-19  8:45 ` Jean-Christophe PLAGNIOL-VILLARD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081119084507.GA9198@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox