public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Bits reversed in ppc4xx.h
Date: Thu, 20 Nov 2008 10:56:41 +0100	[thread overview]
Message-ID: <200811201056.41542.sr@denx.de> (raw)
In-Reply-To: <492438E5.3050900@harris.com>

On Wednesday 19 November 2008, Steven A. Falco wrote:
> The bits in ppc440.h for the SDR0_DDRCFG register are incorrect.  The
> register is numbered in big-endian mode, so for example, the LT2 bit
> (bit 23) should be represented as 0x00000100 rather than 0x01000000.

Those defines are not used anywhere currently. So I would really prefer to 
remove those defines completely. A patch for this would be really 
appreciated. Thanks.

Please note that all 4xx-SDRAM related defines should be placed in 
include/asm-ppc/ppc4xx-sdram.h now.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-11-20  9:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 16:03 [U-Boot] [PATCH] Bits reversed in ppc4xx.h Steven A. Falco
2008-11-20  9:56 ` Stefan Roese [this message]
2008-11-20 15:31   ` [U-Boot] [PATCH] Delete unused definitions for SDR0_DDRCFG from ppc4xx.h Steven A. Falco
2008-11-20 18:07     ` Stefan Roese
2008-11-20 19:37       ` [U-Boot] [PATCH v2] " Steven A. Falco
2008-11-21 10:05         ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811201056.41542.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox