public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Delete unused definitions for SDR0_DDRCFG from ppc4xx.h
Date: Thu, 20 Nov 2008 19:07:19 +0100	[thread overview]
Message-ID: <200811201907.19607.sr@denx.de> (raw)
In-Reply-To: <492582EE.2060207@harris.com>

On Thursday 20 November 2008, Steven A. Falco wrote:
> The definitions of bits in SDR_CFG are incorrect, and not used within
> U-Boot.  Therefore, they can be removed.
>
> Signed-off-by: Steven A. Falco <sfalco@harris.com>
> ---
>
> As per Stefan's request, here is a patch removing the unused, incorrect
> definitions.
>
> Note that the AMCC DDR spreadsheet does calculate a value for the
> sdr_cfg register, so I am leaving the "#define sdr_cfg 0x00e0" in
> place, to make it easier for boards that have to set this register.

Since the register naming is not really correct (SDR0_DDRCFG instead of 
sdr_cfg on 440EPx) I would really like you to remove this define too. And 
sdr_ddrdl too please. If somebody needs them they can be added quickly and 
with the correct naming please (and upper case this time).

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2008-11-20 18:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 16:03 [U-Boot] [PATCH] Bits reversed in ppc4xx.h Steven A. Falco
2008-11-20  9:56 ` Stefan Roese
2008-11-20 15:31   ` [U-Boot] [PATCH] Delete unused definitions for SDR0_DDRCFG from ppc4xx.h Steven A. Falco
2008-11-20 18:07     ` Stefan Roese [this message]
2008-11-20 19:37       ` [U-Boot] [PATCH v2] " Steven A. Falco
2008-11-21 10:05         ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811201907.19607.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox