From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] Minor changes to allow clean creation of new i386/sc520 boards
Date: Thu, 20 Nov 2008 21:21:10 +0100 [thread overview]
Message-ID: <20081120202110.GD20436@game.jcrosoft.org> (raw)
In-Reply-To: <4925BA4F.4070806@gmail.com>
On 06:28 Fri 21 Nov , Graeme Russ wrote:
> Signed-off-by: Graeme Russ <graeme.russ@gmail.com>
> ---
>
> Moved PCI specific definitions out of sc520.h into a new file plus fixed
> include path to ssi.h
please split it in 2 patch
>
> cpu/i386/sc520.c | 2 +-
> include/asm-i386/ic/pci.h | 52 +++++++++++++++++++++++++++++++++++++++++++
> include/asm-i386/ic/sc520.h | 22 ------------------
> 3 files changed, 53 insertions(+), 23 deletions(-)
> create mode 100644 include/asm-i386/ic/pci.h
>
> diff --git a/cpu/i386/sc520.c b/cpu/i386/sc520.c
> index 8bcb979..cb6bc03 100644
> --- a/cpu/i386/sc520.c
> +++ b/cpu/i386/sc520.c
> @@ -32,7 +32,7 @@
> #include <config.h>
> #include <pci.h>
> #ifdef CONFIG_SC520_SSI
> -#include <ssi.h>
> +#include <asm/ic/ssi.h>
> #endif
> #include <asm/io.h>
> #include <asm/pci.h>
> diff --git a/include/asm-i386/ic/pci.h b/include/asm-i386/ic/pci.h
> new file mode 100644
> index 0000000..9721110
> --- /dev/null
> +++ b/include/asm-i386/ic/pci.h
> @@ -0,0 +1,52 @@
> +/*
> + * (C) Copyright 2008
> + * Graeme Russ <graeme.russ@gmail.com>.
you do not do enough modification to add it
Best Regards,
J.
next prev parent reply other threads:[~2008-11-20 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 19:28 [U-Boot] [PATCH 2/2] Minor changes to allow clean creation of new i386/sc520 boards Graeme Russ
2008-11-20 20:21 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-11-21 21:43 ` [U-Boot] [PATCH 2a/2] Fixed path to sc520 SSI include file Graeme Russ
2008-11-21 21:43 ` [U-Boot] [PATCH 2b/2] Moved sc520 PCI definitions to stand-alone file Graeme Russ
2008-12-09 23:33 ` [U-Boot] [PATCH 2/2] Minor changes to allow clean creation of new i386/sc520 boards Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120202110.GD20436@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox