public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] FDT: Enable microblaze cpu in image.c
Date: Mon, 24 Nov 2008 14:02:14 +0100	[thread overview]
Message-ID: <20081124130214.GD30647@game.jcrosoft.org> (raw)
In-Reply-To: <492AA4B9.5060100@monstr.eu>

On 13:57 Mon 24 Nov     , Michal Simek wrote:
> Hi Wolfgang,
> 
> > Dear Michal,
> > 
> >>  
> >> -#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC)
> >> +#if defined(CONFIG_M68K) || defined(CONFIG_MICROBLAZE) || defined(CONFIG_PPC) \
> >> + || defined(CONFIG_SPARC)
> >>  /**
> >>   * boot_ramdisk_high - relocate init ramdisk
> >>   * @lmb: pointer to lmb handle, will be used for memory mgmt
> > 
> > I reject this patch.
> > 
> > I know this is not your fault - you just add to existing code. But the
> > existing code is wrong, and we should not add even more bad code (and
> > rather fix the current, incorrect one).
> > 
> > The thing is that the code  we  are  #ifdef'ing  here  depends  on  a
> > *feature*  (FDT  boot  support),  and thus can be selected on a board
> > level. It is *not* an architecture  thing,  so  it  is  incorrect  to
> > enable or disable it depending on the current arch settings.
> 
> I understand.
> When will be remove this part of code?
> Because without any fix all Microblaze boards can't be successfully compiled.
> 
try my patch

 [PATCH V3] Fix FIT and fdt blob support to have CONFIG_OF_LIBFDT and
 CONFIG_FIT independant

Best Regards,
J.

  reply	other threads:[~2008-11-24 13:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 10:56 [U-Boot] [PATCH 1/4] microblaze: Set up relocation is done monstr at seznam.cz
2008-11-24 10:56 ` [U-Boot] [PATCH 2/4] FDT: Enable microblaze cpu in image.c monstr at seznam.cz
2008-11-24 10:56   ` [U-Boot] [PATCH 3/4] microblaze: Fix ml401 uart16550 setting monstr at seznam.cz
2008-11-24 10:56     ` [U-Boot] [PATCH 4/4] microblaze: ml401, xupv2p, suzaku - add CONFIG_SYS_BOOTMAPSZ and monstr at seznam.cz
2008-11-24 12:51   ` [U-Boot] [PATCH 2/4] FDT: Enable microblaze cpu in image.c Wolfgang Denk
2008-11-24 12:57     ` Michal Simek
2008-11-24 13:02       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2008-11-24 13:23         ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081124130214.GD30647@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox