From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 27 Nov 2008 17:02:18 +0100
Subject: [U-Boot] [PATCH] Added support for the Guntermann & Drunck
	PowerPC 440 EP/GR ETX module.
In-Reply-To: <1227789406-8800-1-git-send-email-eibach@gdsys.de>
References: <1227789406-8800-1-git-send-email-eibach@gdsys.de>
Message-ID: <200811271702.18430.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Dirk,

On Thursday 27 November 2008, Dirk Eibach wrote:
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>

Please find below some comments in addition to Wolfgangs comments:

<snip>

> diff --git a/board/gdsys/gdppc440etx/init.S
> b/board/gdsys/gdppc440etx/init.S new file mode 100644
> index 0000000..f938236
> --- /dev/null
> +++ b/board/gdsys/gdppc440etx/init.S
> @@ -0,0 +1,112 @@
> +/*
> +*
> +* See file CREDITS for list of people who contributed to this
> +* project.
> +*
> +* This program is free software; you can redistribute it and/or
> +* modify it under the terms of the GNU General Public License as
> +* published by the Free Software Foundation; either version 2 of
> +* the License, or (at your option) any later version.
> +*
> +* This program is distributed in the hope that it will be useful,
> +* but WITHOUT ANY WARRANTY; without even the implied warranty of
> +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
> +* GNU General Public License for more details.
> +*
> +* You should have received a copy of the GNU General Public License
> +* along with this program; if not, write to the Free Software
> +* Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +* MA 02111-1307 USA
> +*/
> +
> +#include <ppc_asm.tmpl>
> +#include <config.h>
> +
> +/* General */
> +#define TLB_VALID   0x00000200
> +
> +/* Supported page sizes */
> +
> +#define SZ_1K	    0x00000000
> +#define SZ_4K	    0x00000010
...

Just include:

#include <asm-ppc/mmu.h>

and you get all those defines for free.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================