From: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Added support for the Guntermann & Drunck PowerPC 440 EP/GR ETX module.
Date: Tue, 2 Dec 2008 09:17:20 +0100 [thread overview]
Message-ID: <200812020917.20544.matthias.fuchs@esd-electronics.com> (raw)
In-Reply-To: <1227789406-8800-1-git-send-email-eibach@gdsys.de>
On Thursday 27 November 2008 13:36, Dirk Eibach wrote:
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> +int board_early_init_f(void)
> +{
> + register uint reg;
> +
> + /*--------------------------------------------------------------------
> + * Setup the external bus controller/chip selects
> + *-------------------------------------------------------------------*/
I am sure, but didn't we once said that these dashed lines are ugly and
multiline comments should look like this:
/*
* bla
* bla bla
*/
Matthias
next prev parent reply other threads:[~2008-12-02 8:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 12:36 [U-Boot] [PATCH] Added support for the Guntermann & Drunck PowerPC 440 EP/GR ETX module Dirk Eibach
2008-11-27 15:48 ` Wolfgang Denk
2008-11-28 8:53 ` Eibach, Dirk
2008-11-28 11:40 ` Wolfgang Denk
2008-11-27 16:02 ` Stefan Roese
2008-11-27 17:17 ` Jerry Van Baren
2008-11-27 17:54 ` Stefan Roese
2008-11-27 22:17 ` Wolfgang Denk
2008-12-02 8:17 ` Matthias Fuchs [this message]
2008-12-02 18:41 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812020917.20544.matthias.fuchs@esd-electronics.com \
--to=matthias.fuchs@esd-electronics.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox