public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_elf: CONFIG_ELF_SIMPLE_LOAD: load ELFs according to PHDRs
Date: Fri, 5 Dec 2008 20:02:17 -0500	[thread overview]
Message-ID: <200812052002.18103.vapier@gentoo.org> (raw)
In-Reply-To: <20081205222127.30D68834B020@gemini.denx.de>

On Friday 05 December 2008 17:21:27 Wolfgang Denk wrote:
> In message <1225603202-5757-1-git-send-email-vapier@gentoo.org> you wrote:
> > The current ELF loading function does a lot of work above and beyond a
> > simple "loading".  It ignores the real load addresses and loads things
> > into their virtual (runtime) address.  This is undesirable when we just
> > want it to load an ELF and let the ELF do the actual C runtime init.
>
> I apologize for the late review...
>
> > +#ifdef CONFIG_ELF_SIMPLE_LOAD
> > +unsigned long load_elf_image (unsigned long addr)
>
> ...
>
> ...but would it not make sense to allow to make the decision which
> behaviour fits the user's requirements at runtime instead of compile
> time?
>
> We could either make this depend on some environment variable setting,
> or on a command line option when running the command.
>
>
> If you prefer to stick with the CONFIG_ELF_SIMPLE_LOAD solution, then
> this variable has to be documented in the README.

it doesnt matter to me which route is taken so long as the default can be 
controlled (so via env is ok as you can set the default env values).  if you 
prefer one over the other, let me know.  otherwise simply updating the README 
is the easiest route for me ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20081205/9ba137e8/attachment.pgp 

  reply	other threads:[~2008-12-06  1:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-02  5:20 [U-Boot] [PATCH] cmd_elf: CONFIG_ELF_SIMPLE_LOAD: load ELFs according to PHDRs Mike Frysinger
2008-12-05 22:21 ` Wolfgang Denk
2008-12-06  1:02   ` Mike Frysinger [this message]
2008-12-07  0:21     ` Wolfgang Denk
2010-10-02 19:44 ` [U-Boot] [PATCH] cmd_elf: add an option for loading " Mike Frysinger
2010-10-06 20:42   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812052002.18103.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox