From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Sat, 6 Dec 2008 18:47:56 +0100 Subject: [U-Boot] [patch] make hello world example work for at91sam9261ek and make readme clearer about this In-Reply-To: <3efb10970812050041y199ae0a4la4f4c3589a07fa1@mail.gmail.com> References: <49384d2e.2805420a.5c7b.ffff8d3b@mx.google.com> <20081204214110.GE7336@game.jcrosoft.org> <3efb10970812050041y199ae0a4la4f4c3589a07fa1@mail.gmail.com> Message-ID: <20081206174756.GI2977@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09:41 Fri 05 Dec , Remy Bohmer wrote: > Hello Jean-Christophe, > > >> @@ -33,9 +33,13 @@ ifeq ($(ARCH),arm) > >> ifeq ($(BOARD),omap2420h4) > >> LOAD_ADDR = 0x80300000 > >> else > >> +ifeq ($(BOARD),at91sam9261ek) > >> +LOAD_ADDR = 0x21400000 > >> +else > >> LOAD_ADDR = 0xc100000 > >> endif > >> endif > >> +endif > > Honestly I'll prefer to remove all arch and board ifdef > > and let the board ovewrite it or the arch if the board do not not already define it > > and do here > > LOAD_ADDR ?= > > I completely agree about this. > This was just a minor patch I had on the stack for months and > yesterday I just put them all out. > The most important part of this patch was the comment about the > load-addr in the readme file. > Frequently questions misunderstandings about the examples appear on > the ML, and the readme change would help there. > > I can look into it later on to improve it and find a more generic > solution. In the mean time, I do not think this patch hurts anyone ;-) I'll prefer to wait because I've other patch in queued that will do the samethink Best Regards, J.