public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Althoefer <stefan.althoefer@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 Inc1] IXP425: Fixing PCI access
Date: Mon, 8 Dec 2008 13:24:22 +0100	[thread overview]
Message-ID: <20081208153604.0D7FB51FD1@wolf.teleos-web.de> (raw)
In-Reply-To: <ghetg9$bcs$1@ger.gmane.org>

This fixes conflict existing with IXP425_PCI_SIMPLE_MAPPING.
BAR0 and BAR4 were both defined 0, which prevented external
bus masters from accessing first 16MByte of main memory.

This is an incrmental patch to patch posted 20081206.

Signed-off-by: Stefan Althoefer <stefan.althoefer@web.de>
---
 cpu/ixp/pci.c                        |    3 +--
 include/asm-arm/arch-ixp/ixp425pci.h |    4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/cpu/ixp/pci.c b/cpu/ixp/pci.c
index 6586ba1..e6afb7b 100644
--- a/cpu/ixp/pci.c
+++ b/cpu/ixp/pci.c
@@ -340,11 +340,10 @@ void pci_ixp_init (struct pci_controller *hose)
 	REG_WRITE (PCI_CSR_BASE, PCI_PCIMEMBASE_OFFSET,
 		   IXP425_PCI_PCIMEMBASE_DEFAULT);
 
-	crp_write (PCI_CFG_SUB_VENDOR_ID, IXP425_PCI_SUB_VENDOR_SYSTEM);
-
 	REG_READ (PCI_CSR_BASE, PCI_CSR_OFFSET, regval);
 	regval |= PCI_CSR_IC | PCI_CSR_ABE | PCI_CSR_PDS;
 	REG_WRITE (PCI_CSR_BASE, PCI_CSR_OFFSET, regval);
+
 	crp_write (PCI_CFG_COMMAND, PCI_CFG_CMD_MAE | PCI_CFG_CMD_BME);
 	udelay (1000);
 
diff --git a/include/asm-arm/arch-ixp/ixp425pci.h b/include/asm-arm/arch-ixp/ixp425pci.h
index e533e90..2600d0d 100644
--- a/include/asm-arm/arch-ixp/ixp425pci.h
+++ b/include/asm-arm/arch-ixp/ixp425pci.h
@@ -159,8 +159,8 @@ typedef struct
 #define IXP425_PCI_BAR_1_DEFAULT 0x01000000
 #define IXP425_PCI_BAR_2_DEFAULT 0x02000000
 #define IXP425_PCI_BAR_3_DEFAULT 0x03000000
-#define IXP425_PCI_BAR_4_DEFAULT 0x00000000
-#define IXP425_PCI_BAR_5_DEFAULT 0x00000000
+#define IXP425_PCI_BAR_4_DEFAULT 0xff000000
+#define IXP425_PCI_BAR_5_DEFAULT 0xfffff000
 #else
 #define IXP425_PCI_BAR_0_DEFAULT 0x40000000
 #define IXP425_PCI_BAR_1_DEFAULT 0x41000000
-- 
1.5.4.5

  reply	other threads:[~2008-12-08 12:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-06 22:15 [U-Boot] [PATCH V2 1/1] IXP425: Fixing PCI access Stefan Althoefer
2008-12-08 12:24 ` Stefan Althoefer [this message]
2008-12-15 23:29 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081208153604.0D7FB51FD1@wolf.teleos-web.de \
    --to=stefan.althoefer@web.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox