[U-Boot] [PATCH 1/2][RESEND] Add an SPI driver for PPC440EPx

Wolfgang Denk
2008-12-08T20:21:44Z

Dear Steven,

In message <493D5B65.6020305@harris.com> you wrote:
> This patch adds a SPI driver for the PPC440EPx processor.
>
> Signed-off-by: Steven A. Falco <sfalco@harris.com>
> ---
> Sorry - forgot the subject line, the first time.
>
> cpu/ppc4xx/Makefile | 1 +
> cpu/ppc4xx/spi.c | 128 +++++++++++++++++++++++++++++++++++++++++++++++++++
> include/4xx_spi.h | 50 ++++++++++++++++++++
> 3 files changed, 179 insertions(+), 0 deletions(-)
> create mode 100644 cpu/ppc4xx/spi.c
> create mode 100644 include/4xx_spi.h

Seems you are adding a bare driver here, without any indication of
(potential) users of this driver.

Policy is not to add code that is not really used anywhere.

Do you intend to submit other patches which will require this driver,
or is this driver there "just for the fun of it" ?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You are an excellent tactician, Captain. You let your second in com-
mand attack while you sit and watch for weakness.
-- Khan Noonian Singh, "Space Seed", stardate 3141.9