[U-Boot] [PATCH v2 1/2] ppc4xx: Add 440EPx SPI driver

[Stefan Roese <sr@denx.de>]

On Tuesday 09 December 2008, Wolfgang Denk wrote:
> > > First, thanks for reviewing.  You gave me two different approaches to
> > > consider, 1) using in/out functions, and 2) using a structure.  So, for
> > > this version, I've followed the style of the example you gave, using
> > > the structure approach.
> >
> > No, you _need_ to use the in_/out_() accessor functions. This is
> > unrelated to using plain addresses and offsets vs. a structure. I really
> > welcome the change to the structure in this version, so please just add
> > the in_()/out_() functions upon accessing the SoC registers.
>
> Hm... Seems this is a reply to an off-list message?

No, it's not.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================