From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5] ppc4xx: Add GDsys PowerPC 440 ETX board support.
Date: Tue, 9 Dec 2008 12:07:45 +0100 [thread overview]
Message-ID: <200812091207.45649.sr@denx.de> (raw)
In-Reply-To: <1228819972-5895-1-git-send-email-eibach@gdsys.de>
Hi Dirk,
On Tuesday 09 December 2008, Dirk Eibach wrote:
> Board support for the Guntermann & Drunck PowerPC 440 ETX module.
> Based on the AMCC Yosemite board support by Stefan Roese.
>
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> ---
>
> Depends on [PATCH v3] ppc4xx: Improve DDR autodetect
>
> More whitespace rework.
It's really not a big deal, but since I addressed these issues in my last mail
again, I noticed them in this version as well.
<snip>
> +#define CONFIG_SYS_SDRAM0_TR0 0x410a4012
> +#define CONFIG_SYS_SDRAM0_WDDCTR 0x40000000
Tab after #define! You seem to have missed this one. Did you ever try running
checkpatch on your patch? This should spot such problems.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2008-12-09 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-09 10:52 [U-Boot] [PATCH v5] ppc4xx: Add GDsys PowerPC 440 ETX board support Dirk Eibach
2008-12-09 11:07 ` Stefan Roese [this message]
2008-12-09 11:58 ` Eibach, Dirk
2008-12-09 12:04 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812091207.45649.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox