From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 9 Dec 2008 12:07:45 +0100 Subject: [U-Boot] [PATCH v5] ppc4xx: Add GDsys PowerPC 440 ETX board support. In-Reply-To: <1228819972-5895-1-git-send-email-eibach@gdsys.de> References: <1228819972-5895-1-git-send-email-eibach@gdsys.de> Message-ID: <200812091207.45649.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Dirk, On Tuesday 09 December 2008, Dirk Eibach wrote: > Board support for the Guntermann & Drunck PowerPC 440 ETX module. > Based on the AMCC Yosemite board support by Stefan Roese. > > Signed-off-by: Dirk Eibach > --- > > Depends on [PATCH v3] ppc4xx: Improve DDR autodetect > > More whitespace rework. It's really not a big deal, but since I addressed these issues in my last mail again, I noticed them in this version as well. > +#define CONFIG_SYS_SDRAM0_TR0 0x410a4012 > +#define CONFIG_SYS_SDRAM0_WDDCTR 0x40000000 Tab after #define! You seem to have missed this one. Did you ever try running checkpatch on your patch? This should spot such problems. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================