From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 10 Dec 2008 15:32:59 -0500
Subject: [U-Boot] [PATCH v2] easylogo: add optional gzip support
In-Reply-To: <20081210195727.301BE834B020@gemini.denx.de>
References: <20081210082548.CDC8A834B020@gemini.denx.de>
	<1228934668-20992-1-git-send-email-vapier@gentoo.org>
	<20081210195727.301BE834B020@gemini.denx.de>
Message-ID: <200812101533.00767.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday 10 December 2008 14:57:27 Wolfgang Denk wrote:
> In message ... you wrote:
> > diff --git a/tools/easylogo/easylogo.c b/tools/easylogo/easylogo.c
> > index 00a1e4e..c7e146f 100644
> > --- a/tools/easylogo/easylogo.c
> > +++ b/tools/easylogo/easylogo.c
> > @@ -2,16 +2,20 @@
> >  ** Easylogo TGA->header converter
> >  ** ==============================
> >  ** (C) 2000 by Paolo Scaffardi (arsenio at tin.it)
> > +** (C) 2007-2008 Mike Frysinger <vapier@gentoo.org>
> >  ** AIRVENT SAM s.p.a - RIMINI(ITALY)
>
> This is a bad place to add your copyright - splitting Paolo's entry.

oops, i didnt notice

> > +		if (fread (compressed, st.st_size, 1, gz) != 1) {
> > +			perror ("\nerror: reading gzip data failed");
> > +			return -1;
> > +		}
>
> All the returns above leak the gzfilename and gzcmd memory. Not  that
> it really matters, but it's not clean.

ok

> Also, please omit the "\n" at the begin of the perror strings.

easylogo's output is byte by byte, so no \n means the error message and the 
normal output run together
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20081210/fa15ead5/attachment.pgp