From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SATA: do not auto-initialize during boot
Date: Thu, 11 Dec 2008 15:02:46 -0500 [thread overview]
Message-ID: <200812111502.48970.vapier@gentoo.org> (raw)
In-Reply-To: <13310D5C-93B7-43EA-A46A-266A62B7F1A4@kernel.crashing.org>
On Thursday 11 December 2008 11:18:36 Kumar Gala wrote:
> On Dec 11, 2008, at 4:32 AM, Mike Frysinger wrote:
> > diff --git a/board/freescale/mpc8536ds/mpc8536ds.c b/board/freescale/
> > mpc8536ds/mpc8536ds.c
> > index 2b17612..ada8020 100644
> > --- a/board/freescale/mpc8536ds/mpc8536ds.c
> > +++ b/board/freescale/mpc8536ds/mpc8536ds.c
> > @@ -582,17 +582,6 @@ get_board_ddr_clk(ulong dummy)
> > }
> > #endif
> >
> > -int is_sata_supported(void)
> > -{
> > - volatile ccsr_gur_t *gur = (void *)(CONFIG_SYS_MPC85xx_GUTS_ADDR);
> > - uint sdrs2_io_sel =
> > - (gur->pordevsr & MPC85xx_PORDEVSR_SRDS2_IO_SEL) >> 27;
> > - if (sdrs2_io_sel & 0x04)
> > - return 0;
> > -
> > - return 1;
> > -}
> > -
>
> you removed this but didn't put it anywhere.. that's not going to work.
of course it is going to work. if nothing calls it, why should it exist in
the first place ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20081211/4f61d5be/attachment.pgp
next prev parent reply other threads:[~2008-12-11 20:02 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 8:04 [U-Boot] SATA/IDE/etc... init Mike Frysinger
2008-12-11 10:12 ` Wolfgang Denk
2008-12-11 10:32 ` [U-Boot] [PATCH] SATA: do not auto-initialize during boot Mike Frysinger
2008-12-11 16:17 ` Kumar Gala
2008-12-11 20:03 ` Mike Frysinger
2008-12-11 20:51 ` Kumar Gala
2008-12-11 20:56 ` Mike Frysinger
2008-12-11 21:01 ` Scott Wood
2008-12-11 21:07 ` Mike Frysinger
2008-12-11 21:16 ` Scott Wood
2008-12-11 21:24 ` Mike Frysinger
2008-12-11 21:36 ` Scott Wood
2008-12-11 22:06 ` Mike Frysinger
2008-12-11 23:57 ` Wolfgang Denk
2008-12-23 5:53 ` Mike Frysinger
2008-12-11 23:55 ` Wolfgang Denk
2008-12-11 23:53 ` Wolfgang Denk
2008-12-11 23:57 ` Mike Frysinger
2008-12-12 0:15 ` Scott Wood
2008-12-23 5:51 ` Mike Frysinger
2008-12-11 23:50 ` Wolfgang Denk
2008-12-11 23:49 ` Wolfgang Denk
2008-12-11 16:18 ` Kumar Gala
2008-12-11 20:02 ` Mike Frysinger [this message]
2008-12-11 23:18 ` Wolfgang Denk
2008-12-11 23:26 ` Kumar Gala
2008-12-12 0:01 ` Wolfgang Denk
2008-12-12 0:13 ` Kumar Gala
2008-12-11 12:47 ` [U-Boot] SATA/IDE/etc... init Mike Frysinger
2008-12-11 19:23 ` Scott Wood
2008-12-11 23:22 ` Wolfgang Denk
2008-12-11 23:48 ` Mike Frysinger
2008-12-11 23:51 ` [U-Boot] [PATCH v2] SATA: do not auto-initialize during boot Mike Frysinger
2008-12-12 0:16 ` Kumar Gala
2008-12-23 5:10 ` [U-Boot] [PATCH v3] " Mike Frysinger
2009-01-24 3:12 ` Mike Frysinger
2009-01-27 20:58 ` Wolfgang Denk
2009-01-27 21:12 ` [U-Boot] [PATCH v4] " Mike Frysinger
2009-01-27 22:43 ` Wolfgang Denk
2008-12-12 5:53 ` [U-Boot] SATA/IDE/etc... init Stefan Roese
2008-12-22 7:25 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812111502.48970.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox