From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SATA: do not auto-initialize during boot
Date: Thu, 11 Dec 2008 15:03:53 -0500 [thread overview]
Message-ID: <200812111503.54148.vapier@gentoo.org> (raw)
In-Reply-To: <FB4F5572-E529-45D1-8B72-AD13636814C3@kernel.crashing.org>
On Thursday 11 December 2008 11:17:56 Kumar Gala wrote:
> On Dec 11, 2008, at 4:32 AM, Mike Frysinger wrote:
> > Rather than have the board code initialize SATA automatically during
> > boot,
> > make the user manually run "sata init". This brings the SATA
> > subsystem in
> > line with common U-Boot policy.
> >
> > Along these lines, the "is_sata_supported()" hook is no longer
> > needed, so
> > scrub it from the tree.
> >
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> > board/freescale/mpc8536ds/mpc8536ds.c | 11 -----------
> > common/cmd_sata.c | 7 +++++--
> > include/sata.h | 2 --
> > lib_ppc/board.c | 20 --------------------
> > 4 files changed, 5 insertions(+), 35 deletions(-)
>
> Why should we make the user have to do 'sata init'? That seems
> annoying and easy to forget.
it's already standard behavior with most mass storage things (like mmc and sf
and ...), so it isnt a big deal imo. i asked if Wolfgang wanted it automated
and he preferred making the user do it themselves.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20081211/8a067e61/attachment.pgp
next prev parent reply other threads:[~2008-12-11 20:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 8:04 [U-Boot] SATA/IDE/etc... init Mike Frysinger
2008-12-11 10:12 ` Wolfgang Denk
2008-12-11 10:32 ` [U-Boot] [PATCH] SATA: do not auto-initialize during boot Mike Frysinger
2008-12-11 16:17 ` Kumar Gala
2008-12-11 20:03 ` Mike Frysinger [this message]
2008-12-11 20:51 ` Kumar Gala
2008-12-11 20:56 ` Mike Frysinger
2008-12-11 21:01 ` Scott Wood
2008-12-11 21:07 ` Mike Frysinger
2008-12-11 21:16 ` Scott Wood
2008-12-11 21:24 ` Mike Frysinger
2008-12-11 21:36 ` Scott Wood
2008-12-11 22:06 ` Mike Frysinger
2008-12-11 23:57 ` Wolfgang Denk
2008-12-23 5:53 ` Mike Frysinger
2008-12-11 23:55 ` Wolfgang Denk
2008-12-11 23:53 ` Wolfgang Denk
2008-12-11 23:57 ` Mike Frysinger
2008-12-12 0:15 ` Scott Wood
2008-12-23 5:51 ` Mike Frysinger
2008-12-11 23:50 ` Wolfgang Denk
2008-12-11 23:49 ` Wolfgang Denk
2008-12-11 16:18 ` Kumar Gala
2008-12-11 20:02 ` Mike Frysinger
2008-12-11 23:18 ` Wolfgang Denk
2008-12-11 23:26 ` Kumar Gala
2008-12-12 0:01 ` Wolfgang Denk
2008-12-12 0:13 ` Kumar Gala
2008-12-11 12:47 ` [U-Boot] SATA/IDE/etc... init Mike Frysinger
2008-12-11 19:23 ` Scott Wood
2008-12-11 23:22 ` Wolfgang Denk
2008-12-11 23:48 ` Mike Frysinger
2008-12-11 23:51 ` [U-Boot] [PATCH v2] SATA: do not auto-initialize during boot Mike Frysinger
2008-12-12 0:16 ` Kumar Gala
2008-12-23 5:10 ` [U-Boot] [PATCH v3] " Mike Frysinger
2009-01-24 3:12 ` Mike Frysinger
2009-01-27 20:58 ` Wolfgang Denk
2009-01-27 21:12 ` [U-Boot] [PATCH v4] " Mike Frysinger
2009-01-27 22:43 ` Wolfgang Denk
2008-12-12 5:53 ` [U-Boot] SATA/IDE/etc... init Stefan Roese
2008-12-22 7:25 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812111503.54148.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox