From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_sf: rename "speed" to "hz"
Date: Fri, 12 Dec 2008 00:59:46 +0100 [thread overview]
Message-ID: <20081211235946.86DD08114BC7@gemini.denx.de> (raw)
In-Reply-To: <1229034488-26048-1-git-send-email-vapier@gentoo.org>
Dear Mike Frysinger,
In message <1229034488-26048-1-git-send-email-vapier@gentoo.org> you wrote:
> The term "hz" is used everywhere else when talking about the frequency of
> the SPI bus, so have the sf command use it as well to stay consistent. It
> even presents itself as "hz" when showing user help.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> common/cmd_sf.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/common/cmd_sf.c b/common/cmd_sf.c
> index 8c0a751..902e51d 100644
> --- a/common/cmd_sf.c
> +++ b/common/cmd_sf.c
> @@ -8,8 +8,8 @@
>
> #include <asm/io.h>
>
> -#ifndef CONFIG_SF_DEFAULT_SPEED
> -# define CONFIG_SF_DEFAULT_SPEED 1000000
> +#ifndef CONFIG_SF_DEFAULT_HZ
> +# define CONFIG_SF_DEFAULT_HZ 1000000
I consider "FREQ" (and even "SPEED) a much better name than "HZ".
"HZ" is the unit of what you are measuring, not a name for what you
are measuring.
NAK.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe does not have laws - it has habits, and habits can be
broken.
next prev parent reply other threads:[~2008-12-11 23:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 22:28 [U-Boot] [PATCH] cmd_sf: rename "speed" to "hz" Mike Frysinger
2008-12-11 23:59 ` Wolfgang Denk [this message]
2008-12-12 2:30 ` Mike Frysinger
2008-12-12 7:22 ` Wolfgang Denk
2008-12-22 8:49 ` Mike Frysinger
2008-12-13 18:02 ` Jerry Van Baren
2009-01-06 13:03 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081211235946.86DD08114BC7@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox