From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code Part 1/1
Date: Wed, 17 Dec 2008 00:18:04 +0100 [thread overview]
Message-ID: <20081216231804.GL24266@game.jcrosoft.org> (raw)
In-Reply-To: <gi9a0g$q15$1@ger.gmane.org>
On 23:28 Tue 16 Dec , Stefan Althoefer wrote:
> Jean-Christophe PLAGNIOL-VILLARD schrieb:
> >> + cfg_clk = *IXP425_EXP_CFG0 >> 21;
> > please use readx/writex
>
> The pointer dereference style is used throughout the
> other files in the IXP port as well. Shouldn't this
> be handled the same way in all files?
yes it's old wrong way code
for new we to use the good accessor
for old code patch are welcome
Best Regards,
J.
prev parent reply other threads:[~2008-12-16 23:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 21:09 [U-Boot] [PATCH] IXP425: Changing serial port initialization sequence Part 1/1 Stefan Althoefer
2008-12-04 21:09 ` [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code " Stefan Althoefer
2008-12-04 21:08 ` [U-Boot] [PATCH] ARM: add IDE init to lib_arm/board.c " Stefan Althoefer
2008-12-16 21:58 ` Jean-Christophe PLAGNIOL-VILLARD
2008-12-16 23:19 ` Stefan Althoefer
2008-12-17 12:45 ` michael
2008-12-17 13:10 ` michael
2008-12-17 14:35 ` Jean-Christophe PLAGNIOL-VILLARD
2008-12-17 20:47 ` Stefan Althoefer
2008-12-17 7:56 ` michael
2008-12-16 21:54 ` [U-Boot] [PATCH] IXP425: Improving print_cpuinfo code " Jean-Christophe PLAGNIOL-VILLARD
2008-12-16 22:28 ` Stefan Althoefer
2008-12-16 23:18 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081216231804.GL24266@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox