[U-Boot] [PATCH 0/2] CFI: increase performance

[Stefan Roese <sr@denx.de>]

On Wednesday 17 December 2008, Jens Gehrlein wrote:
> >>>> The following patches should increase the performance of the CFI
> >>>> driver, particularly with regard to single word programming mode.
> >>>>
> >>>> I tested it on TQM5200S with NOR-Flash Samsung K8P2815UQB, which has
> >>>> no write buffer. At least no write buffer, that could be programmed
> >>>> using standard commands.
> >>>>
> >>>> Performance increase on this TQM is about factor 2.6 (37 KiB/s -> 95
> >>>> KiB/s). On the same module with Spansion S29GL128N (with write buffer)
> >>>> it is about factor 1.2 (455 KiB/s -> 585 KiB/s).
> >>>>
> >>>> TQM5200 is a bottom boot module with 2x16 Bit Flash connection. Could
> >>>> someone test the patches on other HW, particularly top boot, other
> >>>> CPU, other flash width, please?
> >>>
> >>> Could you try it against the qemu SVN HEAD
> >>
> >> ??? Sorry, what is qemu SVN HEAD ???
> >
> > In qemu you have 2 boards emulated with u-boot support qemu_mips and SX1
>
> Now, I understand, what you meant.
>
> > it'll be nice to test them also
> >
> > please note they are only in the SVN tree of qemu
>
> Because I'm neither familiar with qemu nor with svn I can't do that
> with little effort (installation, familiarization, etc.). Beside that,
> how could a virtual machine simulate the real bus access with it's
> bus timing? If I'm right in this point, only testing on another
> architecture is possible, but no performance test.
>
> Shortly, I will get a TQM8548 with Samsung Flash. It's a top boot
> system, but also has a 2x16 Bit Flash connection. For my part, I can
> only offer you a test on this board.
>
> Stefan, as the CFI custodian, how is your procedure to check such kind
> of common code patches?

First a review of course. And second tests on multiple boards. It would be 
good if you could test your patch on a few other systems as well. If nobody 
objects, I'll apply your patch to the cfi/next branch in a few days and will 
probably test it on some of my boards too. It will hit mainline in the next 
merge window then.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================