public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] EHCI last patch
Date: Wed, 17 Dec 2008 16:05:03 +0100	[thread overview]
Message-ID: <200812171605.03630.sr@denx.de> (raw)
In-Reply-To: <4948F9B8.5000701@gandalf.sssup.it>

Hi Michael,

On Wednesday 17 December 2008, michael wrote:
> I have rewrite and clean the support for ehci-pci but I don't have any
> hardware to test on it. My
> code is like this:
>
> int ehci_hcd_init(void)
> {
>         pci_dev_t pdev;
>         uint32_t addr;
>
>         pdev = pci_find_devices(ehci_pci_ids, CONFIG_PCI_EHCI_DEVICE);
>         if (dev == -1) {
>                 printf("EHCI host controller not found\n");
>                 return -1;
>         }
>
>         pci_read_config_dword(dev, PCI_BASE_ADDRESS_0, &addr);
>         hccr = (struct ehci_hccr *)addr;
>         hcor = (struct ehci_hcor *)((uint32_t) hccr +
>                         HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
>
>         return 0;
> }
>
> and the CONFIG_PCI_EHCI_DEVICE. I notice that there is a table in
> usb_ohci too. Is there any
> reason?
>
> #ifdef CONFIG_PCI_EHCI_DEVICE
> static struct pci_device_id ehci_pci_ids[] = {
>         /* Please add supported PCI EHCI controller ids here */
>         {0, 0}
> };
> #endif
>
> It is very simple. The problem is thath currently I don't have any other
> hardware to test the code.

That's ok for now. I will test on one of my systems and add the needed PCI 
ID(s).

> I have done some cleanup and I have the ixp4xx usb host support ready
> too. Are there people with ehci
> hardware running u-boot?

There are many, I'm sure. For example some PPC4xx variants which could use 
this EHCI support. So I'm pretty sure that patches for supporting other EHCI 
controllers will follow soon once your patches hit mainline (next merge 
window I suspect).

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

      reply	other threads:[~2008-12-17 15:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-12  9:57 [U-Boot] EHCI last patch michael
2008-12-12 10:05 ` Stefan Roese
2008-12-17 13:08   ` michael
2008-12-17 15:05     ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812171605.03630.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox