From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Mon, 22 Dec 2008 03:49:56 -0500 Subject: [U-Boot] [PATCH] cmd_sf: rename "speed" to "hz" In-Reply-To: <20081212072216.500508356961@gemini.denx.de> References: <1229034488-26048-1-git-send-email-vapier@gentoo.org> <200812112130.02918.vapier@gentoo.org> <20081212072216.500508356961@gemini.denx.de> Message-ID: <200812220349.57529.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 12 December 2008 02:22:16 Wolfgang Denk wrote: > In message <200812112130.02918.vapier@gentoo.org> you wrote: > > > > -#ifndef CONFIG_SF_DEFAULT_SPEED > > > > -# define CONFIG_SF_DEFAULT_SPEED 1000000 > > > > +#ifndef CONFIG_SF_DEFAULT_HZ > > > > +# define CONFIG_SF_DEFAULT_HZ 1000000 > > > > > > I consider "FREQ" (and even "SPEED) a much better name than "HZ". > > > > > > "HZ" is the unit of what you are measuring, not a name for what you > > > are measuring. > > > > then they should all be converted. not 90% using hz and 10% using > > something > > Agreed. > > > else. "speed" is bad as it doesnt convey the unit while "hz" is pretty > > clear. > > You are right, but that could be mentioned in the documentation > then... that seems silly to me. we can either have self-explaining defines, or confusing ones which requires people to read the documentation to figure out ? -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20081222/0bdb61b1/attachment.pgp