public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC][PATCH] Code Clean-up (weak functions)
Date: Mon, 22 Dec 2008 06:44:12 -0500	[thread overview]
Message-ID: <200812220644.13237.vapier@gentoo.org> (raw)
In-Reply-To: <d66caabb0812220116s76282a8s3d63a11701f9739a@mail.gmail.com>

On Monday 22 December 2008 04:16:33 Graeme Russ wrote:
> On Mon, Dec 22, 2008 at 8:05 PM, Mike Frysinger wrote:
> > On Saturday 13 December 2008 00:26:26 Graeme Russ wrote:
> >> This patch makes all definitions, declarations and usages of weak
> >> functions consistent.
> >
> > a quick glance shows that it breaks things (the ELF and Blackfin stuff
> > certainly appears to be wrong).  i'm guessing you focused on style for
> > the RFC part rather than the result actually being correct ...
> > -mike
>
> Thanks for having a look at this. Would it be possible for you to be a bit
> more specific about 'wrong' if for nothing other that me gaining a better
> understanding of how it works, and how it breaks

you set the aliases to functions that do not exist
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20081222/9561f07d/attachment.pgp 

  reply	other threads:[~2008-12-22 11:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-13  5:26 [U-Boot] [RFC][PATCH] Code Clean-up (weak functions) Graeme Russ
2008-12-13 22:48 ` Remy Bohmer
2008-12-14  9:23   ` Graeme Russ
2008-12-22  9:05 ` Mike Frysinger
2008-12-22  9:16   ` Graeme Russ
2008-12-22 11:44     ` Mike Frysinger [this message]
2008-12-22 11:20       ` Graeme Russ
2008-12-23  4:18         ` Mike Frysinger
2008-12-24  1:14 ` Shinya Kuribayashi
2008-12-24 14:12   ` Joakim Tjernlund
2008-12-24 16:55     ` Shinya Kuribayashi
2008-12-24 19:41       ` Remy Bohmer
2008-12-25  0:56         ` Shinya Kuribayashi
2008-12-25 11:26           ` Graeme Russ
2008-12-25 14:00       ` Joakim Tjernlund
2008-12-25 14:39         ` Shinya Kuribayashi
2008-12-25 11:22   ` Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812220644.13237.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox