public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] make make quiet
Date: Wed, 31 Dec 2008 04:46:18 -0500	[thread overview]
Message-ID: <200812310446.19804.vapier@gentoo.org> (raw)
In-Reply-To: <1230715433.19628.12.camel@duo>

On Wednesday 31 December 2008 04:23:53 kenneth johansson wrote:
> On Tue, 2008-12-30 at 23:14 +0100, Wolfgang Denk wrote:
> > Dear kenneth johansson,
> >
> > In message <1230636057.17914.5.camel@duo> you wrote:
> > > Only print out the target name during make.
> > > For old style set V=1
> >
> > What is the rationale for this patch? I can see no real advantage with
> > it.
>
> To highlight warnings during build. It's just a way to make the default
> output less noise.
>
> > If you find the make output annoying, you can silence make by passing
> > the "-s" flag.
>
> -s is a bit to much you get no feedback at all.

you may want to include this kind of "usage" in the changelog

> with errors I guess you mean non optimal output. the patch really should
> not have any impact on the binaries built. If it really breaks the build
> that is a real problem and one I do not see in my test.

i dont really like how the changes are integrated.  it'll require constant 
maintenance to add these QUIET prefix vars.  is there a reason we cant go the 
opposite direction and set CC/etc... directly ?  or try unifying things with 
patterns ?

i.e. drop all of the $(AR) calls in board/*/Makefile and replace it with a 
toplevel pattern kind of like:
%.a: %.o
	$(AR) $(ARFLAGS) $^ -o $@
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20081231/b804c620/attachment-0001.pgp 

  reply	other threads:[~2008-12-31  9:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30 11:20 [U-Boot] [PATCH] make make quiet kenneth johansson
2008-12-30 22:14 ` Wolfgang Denk
2008-12-30 22:28   ` Scott Wood
2008-12-30 23:30     ` Wolfgang Denk
2008-12-31  9:23   ` kenneth johansson
2008-12-31  9:46     ` Mike Frysinger [this message]
2008-12-31 10:06       ` kenneth johansson
2008-12-31 11:15         ` Mike Frysinger
2008-12-31 12:04           ` kenneth johansson
2008-12-31 19:47     ` Wolfgang Denk
2009-01-05 19:53       ` Scott Wood
2009-01-05 21:13         ` Wolfgang Denk
2009-01-05 20:30       ` Remy Bohmer
2009-01-05 21:20         ` Wolfgang Denk
2009-01-06 20:16 ` Robert Schwebel
  -- strict thread matches above, loose matches on Subject: below --
2008-12-30  8:25 kenneth johansson
2008-12-30 10:48 ` Wolfgang Denk
2008-12-30 11:07   ` kenneth johansson
2008-12-30 21:46     ` Wolfgang Denk
2008-12-31  9:11 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812310446.19804.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox