From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 31 Dec 2008 04:46:18 -0500 Subject: [U-Boot] [PATCH] make make quiet In-Reply-To: <1230715433.19628.12.camel@duo> References: <1230636057.17914.5.camel@duo> <20081230221406.D7BEC8225019@gemini.denx.de> <1230715433.19628.12.camel@duo> Message-ID: <200812310446.19804.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 31 December 2008 04:23:53 kenneth johansson wrote: > On Tue, 2008-12-30 at 23:14 +0100, Wolfgang Denk wrote: > > Dear kenneth johansson, > > > > In message <1230636057.17914.5.camel@duo> you wrote: > > > Only print out the target name during make. > > > For old style set V=1 > > > > What is the rationale for this patch? I can see no real advantage with > > it. > > To highlight warnings during build. It's just a way to make the default > output less noise. > > > If you find the make output annoying, you can silence make by passing > > the "-s" flag. > > -s is a bit to much you get no feedback at all. you may want to include this kind of "usage" in the changelog > with errors I guess you mean non optimal output. the patch really should > not have any impact on the binaries built. If it really breaks the build > that is a real problem and one I do not see in my test. i dont really like how the changes are integrated. it'll require constant maintenance to add these QUIET prefix vars. is there a reason we cant go the opposite direction and set CC/etc... directly ? or try unifying things with patterns ? i.e. drop all of the $(AR) calls in board/*/Makefile and replace it with a toplevel pattern kind of like: %.a: %.o $(AR) $(ARFLAGS) $^ -o $@ -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20081231/b804c620/attachment-0001.pgp