From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] make make quiet
Date: Wed, 31 Dec 2008 20:47:54 +0100 [thread overview]
Message-ID: <20081231194754.662C685AD247@gemini.denx.de> (raw)
In-Reply-To: <1230715433.19628.12.camel@duo>
Dear kenneth johansson,
In message <1230715433.19628.12.camel@duo> you wrote:
>
> > If you find the make output annoying, you can silence make by passing
> > the "-s" flag.
>
> -s is a bit to much you get no feedback at all.
But that's the preferred way of doing things, at least according to
Unix Philosophy.
No news is good news. Running a "./MAKEALL <boardname>" on a somewhat
decent machine takes no more than 10...20 seconds. Either you get
warnings / error messages, or not. What else is needed?
> > On the other hand, your patch braks building with "-s" - I get:
>
> oops that was not intended.
>
> > Even without "-s" there are some errors for example when I try to
> > build the "TQM5200" configuration.
>
> with errors I guess you mean non optimal output. the patch really should
No, with errors I mean things like "grep: writing output: Broken pipe".
> > Unless you have a really good reason why this patch should be
> > applied, I tend to reject it.
>
> No it's only a way to remove most of the noise as mentioned it has no
> effect on u-boot itself.
If you want to have a silent build (which I do almost always, too),
then either use "./MAKEALL <boardname>" or "make -s".
> while it's a large patch it's mostly trivial search/replace so it's easy
> to remove should people object to it.
I diasgree. The changes are far from trivial.
> here is a small addition to the patch fixing the issues with -s you
> found.
I think your appraoch (and that of kbuild, too) is fundamentally
broken. Fixing this on the Makefile level is at least one level to
far up. If you really want a verbosity level of make that is between
no options (normal case) and no output (except warnings/errors, as
with -s), then this should be implemnted within make itself, as a new
make option.Then you have the changes in one place only, and each and
every software package can benefit from it. Modifying hundrets of
Makefiles here and there and then again for each new software package
makes absolutely no sense to me.
U-Boot is the wrong place to fix this. Please fix this in make, for
the benefit of others, too.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Substitute "damn" every time you're inclined to write "very"; your
editor will delete it and the writing will be just as it should be.
- Mark Twain
next prev parent reply other threads:[~2008-12-31 19:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-30 11:20 [U-Boot] [PATCH] make make quiet kenneth johansson
2008-12-30 22:14 ` Wolfgang Denk
2008-12-30 22:28 ` Scott Wood
2008-12-30 23:30 ` Wolfgang Denk
2008-12-31 9:23 ` kenneth johansson
2008-12-31 9:46 ` Mike Frysinger
2008-12-31 10:06 ` kenneth johansson
2008-12-31 11:15 ` Mike Frysinger
2008-12-31 12:04 ` kenneth johansson
2008-12-31 19:47 ` Wolfgang Denk [this message]
2009-01-05 19:53 ` Scott Wood
2009-01-05 21:13 ` Wolfgang Denk
2009-01-05 20:30 ` Remy Bohmer
2009-01-05 21:20 ` Wolfgang Denk
2009-01-06 20:16 ` Robert Schwebel
-- strict thread matches above, loose matches on Subject: below --
2008-12-30 8:25 kenneth johansson
2008-12-30 10:48 ` Wolfgang Denk
2008-12-30 11:07 ` kenneth johansson
2008-12-30 21:46 ` Wolfgang Denk
2008-12-31 9:11 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081231194754.662C685AD247@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox